Bug 35395

Summary:	Update description of DefaultPatronSearchMethod
Product:	Koha	Reporter:	Magnus Enger <magnus>
Component:	System Administration	Assignee:	Katrin Fischer <katrin.fischer>
Status:	Pushed to stable ---	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, nick
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.05.00,23.11.02
Circulation function:
Attachments:	Bug 35395: Update DefaultPatronSearchMethod system preference description Bug 35395: Update DefaultPatronSearchMethod system preference description Bug 35395: Update DefaultPatronSearchMethod system preference description

Description Magnus Enger 2023-11-24 10:49:22 UTC

DefaultPatronSearchMethod was added in bug 33117. The description is: 

         - pref: DefaultPatronSearchMethod
           choices:
               starts_with: "Starts with"
               contains: "Contains"
         - Enable this search method to determine whether to use Starts with or Contains for autocomplete patron searches.

The original name of the syspref was PatronAutoCompleteSearchMethod, but this was changed in attachment 152564 [details] [review], with this comment: 

"As it's been requested that we keep the search defaults consistent, I
think this preference is better names DefaultPatronSearchMethod and
appear next to DefaultPatronSearchFields. This patch makes that change,
though actually applying it to the other search area's (outside of
autocomplete) has been left for another bug."

I *think* the "another bug" is bug 35127, but at least testing shows that DefaultPatronSearchMethod now applies to the actual search as well as the autocomplete. So the description of DefaultPatronSearchMethod should be updated so it is clear that it applies both to autocomplete and the actual search.

Comment 1 Katrin Fischer 2024-01-06 20:30:33 UTC

Created attachment 160604 [details] [review]
Bug 35395: Update DefaultPatronSearchMethod system preference description

This updates the system preference description of DefaultPatronSearchMethod
so that it's clear that the preference applies to all patron
searches, including patron module search and auto-completes.

To test:
* Search for DefaultPatronSearchMethod system preference in administration
* Verify the setting is reflected in the filters of the patron search
* Apply patch
* Verify that the description now is now improved.

Comment 2 David Nind 2024-01-07 15:05:13 UTC

Created attachment 160611 [details] [review]
Bug 35395: Update DefaultPatronSearchMethod system preference description

This updates the system preference description of DefaultPatronSearchMethod
so that it's clear that the preference applies to all patron
searches, including patron module search and auto-completes.

To test:
* Search for DefaultPatronSearchMethod system preference in administration
* Verify the setting is reflected in the filters of the patron search
* Apply patch
* Verify that the description now is now improved.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Nick Clemens (kidclamp) 2024-01-08 12:40:44 UTC

Created attachment 160624 [details] [review]
Bug 35395: Update DefaultPatronSearchMethod system preference description

This updates the system preference description of DefaultPatronSearchMethod
so that it's clear that the preference applies to all patron
searches, including patron module search and auto-completes.

To test:
* Search for DefaultPatronSearchMethod system preference in administration
* Verify the setting is reflected in the filters of the patron search
* Apply patch
* Verify that the description now is now improved.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 4 Katrin Fischer 2024-01-11 14:49:57 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 5 Fridolin Somers 2024-01-15 14:09:50 UTC

Pushed to 23.11.x for 23.11.02