Go to Patrons. Click the right context menu. Select the other option than the one selected. (Depends on a pref.) Search for some user. Verify that the searchtype has not been used correctly.
This is on master, but I saw it on 22.11 too
Seems that bug 33117 broken this.
Created attachment 157745 [details] [review] Bug 35127: Fix 'Search type' for patron search We need to fallback on the syspref DefaultPatronSearchMethod but keep the value when one is passed! Test plan: Search for patrons, and use the "search type". Set it to different values than DefaultPatronSearchMethod and confirm that the value is kept. Fix is expected when searching for patrons in the header (use the options to select a different value and run the search)
Created attachment 157752 [details] [review] Bug 35127: Fix 'Search type' for patron search We need to fallback on the syspref DefaultPatronSearchMethod but keep the value when one is passed! Test plan: Search for patrons, and use the "search type". Set it to different values than DefaultPatronSearchMethod and confirm that the value is kept. Fix is expected when searching for patrons in the header (use the options to select a different value and run the search) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 157784 [details] [review] Bug 35127: Fix 'Search type' for patron search We need to fallback on the syspref DefaultPatronSearchMethod but keep the value when one is passed! Test plan: Search for patrons, and use the "search type". Set it to different values than DefaultPatronSearchMethod and confirm that the value is kept. Fix is expected when searching for patrons in the header (use the options to select a different value and run the search) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thx for a quick fix, Jonathan.
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x