Summary: | 856 label is inconsistent between detail page and search results in XSLTs | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Searching | Assignee: | David Nind <david> |
Status: | Pushed to oldoldstable --- | QA Contact: | David Cook <dcook> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, phil |
Version: | Main | Keywords: | Academy, Sandbox |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This updates the default staff interface and OPAC XSLT files so that "Online resources" is used as the label in search results for field 856 - Electronic Location and Access, instead of "Online access". This matches the label used in the detail page for a record.
It also adjusts the CSS class so OPAC and staff interface both use online_resources.
|
Version(s) released in: |
24.05.00,23.11.01,23.05.07
|
Circulation function: | |||
Attachments: |
Bug 35410: Use "Online resources" label in search results
Bug 35410: Use "Online resources" label in search results Bug 35410: Use "Online resources" label in search results Bug 35410: Use "Online resources" label in search results |
Description
David Cook
2023-11-28 02:52:47 UTC
I think both "Online access" and "Online resources" are equally descriptive, so how do we pick one? For me 'online resources' is the broader term which I think would be a better fit since currently we show all links together, not differentiating between full text and other links (covers, TOCs, reviews, etc.). (In reply to Katrin Fischer from comment #2) > For me 'online resources' is the broader term which I think would be a > better fit since currently we show all links together, not differentiating > between full text and other links (covers, TOCs, reviews, etc.). Sounds good to me! Created attachment 159513 [details] [review] Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind <david@davidnind.com> Created attachment 159514 [details] [review] Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind <david@davidnind.com> Legend! I was just thinking how I needed to get around to this, so thanks for taking care of it :). I might let someone else sign off so that I can QA it. From what I can tell, no update for UNIMARC is required. Created attachment 159562 [details] [review] Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 159565 [details] [review] Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Thanks Lucas for the sign-off and David for the QA! David Pushed for 24.05! Well done everyone, thank you! Note: I like the consistency of the change to the class, but it could have some side effects for existing CSS. I decided to push, because the change is in the staff interface, not in the OPAC. Pushed to 23.11.x for 23.11.01 (In reply to Katrin Fischer from comment #13) > Note: I like the consistency of the change to the class, but it could have > some side effects for existing CSS. I decided to push, because the change is > in the staff interface, not in the OPAC. I was thinking the same thing. Initially, I thought we should've kept the existing class and added the new one, but then I figured since it's the staff interface people can just update on upgrade as needed. Backported to 23.05.x for upcoming 23.05.07 |