| Summary: | Terminology: differentiate issues for vendor issues and serials | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, lucas, tomascohen, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35417 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.02
|
|
| Circulation function: | |||
| Attachments: |
Bug 35413: Terminology: Manage issues (issue_manage)
Bug 35413: Terminology: Manage issues (issue_manage) Bug 35413: Terminology: Manage issues (issue_manage) Bug 35413: DB update |
||
|
Description
Katrin Fischer
2023-11-28 12:23:15 UTC
Created attachment 159303 [details] [review] Bug 35413: Terminology: Manage issues (issue_manage) This patch updates several files which use the term "issues" without context, changing them to "Vendor issues." Unchanged is the vendor issues page template, vendor_issues.tt, which is updated in Bug 35417. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - You should see a "Vendor issues" link in the sidebar. - Go to Patrons and search for a patron. View the patron's details. - Click More -> Set permissions. - Under Acquisitions management you should see "Manage vendor issues (issue_manage)" Created attachment 159319 [details] [review] Bug 35413: Terminology: Manage issues (issue_manage) This patch updates several files which use the term "issues" without context, changing them to "Vendor issues." Unchanged is the vendor issues page template, vendor_issues.tt, which is updated in Bug 35417. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - You should see a "Vendor issues" link in the sidebar. - Go to Patrons and search for a patron. View the patron's details. - Click More -> Set permissions. - Under Acquisitions management you should see "Manage vendor issues (issue_manage)" Signed-off-by: David Nind <david@davidnind.com> Thx for fixing the navigation! I ran into this today as it's the same string for serials and vendor issues currently. This will help a lot. Shouldn't there be a database migration for existing installs? Because they will still have the old description: select * from permissions where code = 'issue_manage'; | module_bit | code | description | | 11 | issue_manage | Manage issues | Or maybe it doesn't matter because where is permissions.description used anyway? The test plan seems to looks in the right places and they don't use permissions.description. Otherwise, all looks good. Created attachment 159964 [details] [review] Bug 35413: Terminology: Manage issues (issue_manage) This patch updates several files which use the term "issues" without context, changing them to "Vendor issues." Unchanged is the vendor issues page template, vendor_issues.tt, which is updated in Bug 35417. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - You should see a "Vendor issues" link in the sidebar. - Go to Patrons and search for a patron. View the patron's details. - Click More -> Set permissions. - Under Acquisitions management you should see "Manage vendor issues (issue_manage)" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 159965 [details] [review] Bug 35413: DB update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Victor Grousset/tuxayo from comment #4) > Shouldn't there be a database migration for existing installs? Because they > will still have the old description: Done. I don't think it is really an issue (cuack) but until we remove the unused column, we should always keep updated DB similar to fresh installs. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Doesn't apply cleanly to 23.05.x, no backport. |