We still have these lines in translations: %s %s Modify vendor issue %s New vendor issue %s › %s %s Confirm deletion of vendor issue › %s %s Vendor issue › Acquisition › Koha Shows that we need to update them to the new structure still :)
Created attachment 159302 [details] [review] Bug 35417: Update breadcrumbs and page titles for vendor issues This patch updates the vendor issues template so that title and breadcrumbs follow the same pattern on other updated templates: Translatable strings in the title and breadcrumbs using the template WRAPPER. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - Click the "Isssues" link in the sidebar. - Check that the page title and breadcrumbs are correct in each variation of the page: - The main page - New vendor issue - Modify vendor issue - Issue deletion confirmation
Created attachment 159320 [details] [review] Bug 35417: Update breadcrumbs and page titles for vendor issues This patch updates the vendor issues template so that title and breadcrumbs follow the same pattern on other updated templates: Translatable strings in the title and breadcrumbs using the template WRAPPER. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - Click the "Isssues" link in the sidebar. - Check that the page title and breadcrumbs are correct in each variation of the page: - The main page - New vendor issue - Modify vendor issue - Issue deletion confirmation Signed-off-by: David Nind <david@davidnind.com>
Created attachment 160012 [details] [review] Bug 35417: Update breadcrumbs and page titles for vendor issues This patch updates the vendor issues template so that title and breadcrumbs follow the same pattern on other updated templates: Translatable strings in the title and breadcrumbs using the template WRAPPER. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - Click the "Isssues" link in the sidebar. - Check that the page title and breadcrumbs are correct in each variation of the page: - The main page - New vendor issue - Modify vendor issue - Issue deletion confirmation Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks Owen, Passing QA.. all working as expected :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Doesn't apply cleanly to 23.05.x, no backport.