Summary: | Unexpected translation string for Suggestions template | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.04
|
|
Circulation function: | |||
Bug Depends on: | 33908 | ||
Bug Blocks: | |||
Attachments: |
Bug 35422: Fix translation of suggestions title tag
Bug 35422: Fix translation of suggestions title tag Bug 35422: Fix translation of suggestions title tag |
Description
Katrin Fischer
2023-11-28 15:17:06 UTC
Created attachment 159304 [details] [review] Bug 35422: Fix translation of suggestions title tag This patch corrects a missed instance of a string in the title tag which should have been wrapped in the translation function [% t() %] To test, apply the patch and go to Suggestions. - Click "New purchase suggestion" - The title of the page should be correct: "Add suggestion" - Confirm that translation is improved: - Update and reinstall active translations (for instance fr-FR): perl misc/translator/translate update fr-FR - Check the corresponding po file, in this case fr-FR-messages.po - There should be an entry for the string "Add suggestion" Created attachment 159326 [details] [review] Bug 35422: Fix translation of suggestions title tag This patch corrects a missed instance of a string in the title tag which should have been wrapped in the translation function [% t() %] To test, apply the patch and go to Suggestions. - Click "New purchase suggestion" - The title of the page should be correct: "Add suggestion" - Confirm that translation is improved: - Update and reinstall active translations (for instance fr-FR): perl misc/translator/translate update fr-FR - Check the corresponding po file, in this case fr-FR-messages.po - There should be an entry for the string "Add suggestion" Signed-off-by: David Nind <david@davidnind.com> Created attachment 161504 [details] [review] Bug 35422: Fix translation of suggestions title tag This patch corrects a missed instance of a string in the title tag which should have been wrapped in the translation function [% t() %] To test, apply the patch and go to Suggestions. - Click "New purchase suggestion" - The title of the page should be correct: "Add suggestion" - Confirm that translation is improved: - Update and reinstall active translations (for instance fr-FR): perl misc/translator/translate update fr-FR - Check the corresponding po file, in this case fr-FR-messages.po - There should be an entry for the string "Add suggestion" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.04 Missing 23.05.x dependencies, no backport. |