Bug 35422 - Unexpected translation string for Suggestions template
Summary: Unexpected translation string for Suggestions template
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-28 15:17 UTC by Katrin Fischer
Modified: 2024-01-31 21:50 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35422: Fix translation of suggestions title tag (1.65 KB, patch)
2023-11-28 17:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35422: Fix translation of suggestions title tag (1.70 KB, patch)
2023-11-29 10:36 UTC, David Nind
Details | Diff | Splinter Review
Bug 35422: Fix translation of suggestions title tag (1.79 KB, patch)
2024-01-26 10:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-28 15:17:06 UTC
This string didn't get broken up as expected:

koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:11 

%s %s %s %s › %s Add suggestion › %s %s %s › %s %s › %s › %s %s

Maybe we need to wrap the "Add suggestion" as well?
Comment 1 Owen Leonard 2023-11-28 17:02:55 UTC
Created attachment 159304 [details] [review]
Bug 35422: Fix translation of suggestions title tag

This patch corrects a missed instance of a string in the title tag which
should have been wrapped in the translation function [% t() %]

To test, apply the patch and go to Suggestions.

- Click "New purchase suggestion"
- The title of the page should be correct: "Add suggestion"
- Confirm that translation is improved:
  - Update and reinstall active translations (for instance fr-FR):
    perl misc/translator/translate update fr-FR
  - Check the corresponding po file, in this case fr-FR-messages.po
  - There should be an entry for the string "Add suggestion"
Comment 2 David Nind 2023-11-29 10:36:11 UTC
Created attachment 159326 [details] [review]
Bug 35422: Fix translation of suggestions title tag

This patch corrects a missed instance of a string in the title tag which
should have been wrapped in the translation function [% t() %]

To test, apply the patch and go to Suggestions.

- Click "New purchase suggestion"
- The title of the page should be correct: "Add suggestion"
- Confirm that translation is improved:
  - Update and reinstall active translations (for instance fr-FR):
    perl misc/translator/translate update fr-FR
  - Check the corresponding po file, in this case fr-FR-messages.po
  - There should be an entry for the string "Add suggestion"

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-01-26 10:49:25 UTC
Created attachment 161504 [details] [review]
Bug 35422: Fix translation of suggestions title tag

This patch corrects a missed instance of a string in the title tag which
should have been wrapped in the translation function [% t() %]

To test, apply the patch and go to Suggestions.

- Click "New purchase suggestion"
- The title of the page should be correct: "Add suggestion"
- Confirm that translation is improved:
  - Update and reinstall active translations (for instance fr-FR):
    perl misc/translator/translate update fr-FR
  - Check the corresponding po file, in this case fr-FR-messages.po
  - There should be an entry for the string "Add suggestion"

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>