This string didn't get broken up as expected: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt:11 %s %s %s %s › %s Add suggestion › %s %s %s › %s %s › %s › %s %s Maybe we need to wrap the "Add suggestion" as well?
Created attachment 159304 [details] [review] Bug 35422: Fix translation of suggestions title tag This patch corrects a missed instance of a string in the title tag which should have been wrapped in the translation function [% t() %] To test, apply the patch and go to Suggestions. - Click "New purchase suggestion" - The title of the page should be correct: "Add suggestion" - Confirm that translation is improved: - Update and reinstall active translations (for instance fr-FR): perl misc/translator/translate update fr-FR - Check the corresponding po file, in this case fr-FR-messages.po - There should be an entry for the string "Add suggestion"
Created attachment 159326 [details] [review] Bug 35422: Fix translation of suggestions title tag This patch corrects a missed instance of a string in the title tag which should have been wrapped in the translation function [% t() %] To test, apply the patch and go to Suggestions. - Click "New purchase suggestion" - The title of the page should be correct: "Add suggestion" - Confirm that translation is improved: - Update and reinstall active translations (for instance fr-FR): perl misc/translator/translate update fr-FR - Check the corresponding po file, in this case fr-FR-messages.po - There should be an entry for the string "Add suggestion" Signed-off-by: David Nind <david@davidnind.com>
Created attachment 161504 [details] [review] Bug 35422: Fix translation of suggestions title tag This patch corrects a missed instance of a string in the title tag which should have been wrapped in the translation function [% t() %] To test, apply the patch and go to Suggestions. - Click "New purchase suggestion" - The title of the page should be correct: "Add suggestion" - Confirm that translation is improved: - Update and reinstall active translations (for instance fr-FR): perl misc/translator/translate update fr-FR - Check the corresponding po file, in this case fr-FR-messages.po - There should be an entry for the string "Add suggestion" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.04
Missing 23.05.x dependencies, no backport.