| Summary: | AuthoritiesMarc: Warnings substr outside of string and Use of uninitialized value $type in string eq | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Lari Taskula <lari.taskula> |
| Status: | Pushed to main --- | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | aleisha |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
26.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 2505 | ||
| Attachments: |
Bug 35423: Fix substr outside of string warning
Bug 35423: Fix substr outside of string warning Bug 35423: Fix substr outside of string warning Bug 35423: Fix substr outside of string warning |
||
|
Description
Marcel de Rooy
2023-11-28 15:19:04 UTC
Created attachment 188258 [details] [review] Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged Tip to recreate for tester, using KTD: Go to http://localhost:8081/cgi-bin/koha/authorities/detail.pl?authid=1630 Edit record Go to 400 tab and add "n" to 400$w In your commandline, watch the log by running tail -f /var/log/koha/kohadev/plack-intranet-error.log Then go to Authorities and do a main heading search for "a" Created attachment 191831 [details] [review] Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged Hi Harrison, it looks like you meant to sign this off, but your sign-off line is missing from the patch. If you use ktd you can fix this by: - Create a branch and apply the patch - git so 1 - git bz attach 35432 HEAD You might also want to check what the sign-off line looks like to verify your email and name are set up as you want it :) Created attachment 191837 [details] [review] Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged Signed-off-by: Harrison Hawkins <harrisonhawkins@catalyst.net.nz> Quick! Back to this one.... Created attachment 191842 [details] [review] Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged Signed-off-by: Harrison Hawkins <harrisonhawkins@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to main for 26.05 |