In full: substr outside of string at /usr/share/koha/C4/AuthoritiesMarc.pm line 1041. Use of uninitialized value $type in string eq at /usr/share/koha/C4/AuthoritiesMarc.pm line 1044. May be found in your logs (depending on data) when calling SearchAuthorities.
Created attachment 188258 [details] [review] Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged
Tip to recreate for tester, using KTD: Go to http://localhost:8081/cgi-bin/koha/authorities/detail.pl?authid=1630 Edit record Go to 400 tab and add "n" to 400$w In your commandline, watch the log by running tail -f /var/log/koha/kohadev/plack-intranet-error.log Then go to Authorities and do a main heading search for "a"
Created attachment 191831 [details] [review] Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged
Hi Harrison, it looks like you meant to sign this off, but your sign-off line is missing from the patch. If you use ktd you can fix this by: - Create a branch and apply the patch - git so 1 - git bz attach 35432 HEAD You might also want to check what the sign-off line looks like to verify your email and name are set up as you want it :)
Created attachment 191837 [details] [review] Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged Signed-off-by: Harrison Hawkins <harrisonhawkins@catalyst.net.nz>
Quick! Back to this one....
Created attachment 191842 [details] [review] Bug 35423: Fix substr outside of string warning To test: Before applying patch 1. Create an authority record, fill field 400$w with "n" 2. Search for the authority you just created 3. Observe a warning has been logged "substr outside of string" 4. Apply patch 5. Refresh the search results from step 2 6. Observe no warnings have been logged Signed-off-by: Harrison Hawkins <harrisonhawkins@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to main for 26.05