| Summary: | Script migration_tools/build_oai_sets.pl is missing ORDER BY | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Web services | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | Pushed to stable --- | QA Contact: | Julian Maurice <julian.maurice> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | julian.maurice, lucas, martin.renvoize, pedro.amorim |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33627 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER BY
Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER BY Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER BY |
||
|
Description
Fridolin Somers
2023-11-29 19:52:20 UTC
Created attachment 159367 [details] [review] Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER BY Script migration_tools/build_oai_sets.pl is missing ORDER BY biblionumber. This is a problem when using OFFSET and LIMIT, the results may be differenly orderder between two calls of this script. Test plan : 1) Create a OAI SET with all records 2) Run migration_tools/build_oai_sets.pl with the first half of records 3) Run migration_tools/build_oai_sets.pl with the second half of records 4) Check all records are in the OAI set Created attachment 166783 [details] [review] Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER BY Script migration_tools/build_oai_sets.pl is missing ORDER BY biblionumber. This is a problem when using OFFSET and LIMIT, the results may be differenly orderder between two calls of this script. Test plan : 1) Create a OAI SET with all records 2) Run migration_tools/build_oai_sets.pl with the first half of records 3) Run migration_tools/build_oai_sets.pl with the second half of records 4) Check all records are in the OAI set Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 171830 [details] [review] Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER BY Script migration_tools/build_oai_sets.pl is missing ORDER BY biblionumber. This is a problem when using OFFSET and LIMIT, the results may be differenly orderder between two calls of this script. Test plan : 1) Create a OAI SET with all records 2) Run migration_tools/build_oai_sets.pl with the first half of records 3) Run migration_tools/build_oai_sets.pl with the second half of records 4) Check all records are in the OAI set Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> The patch is from BibLibre but it's a bugfix that has been in the QA queue for 4 months. I hope it's okay that I QA it. Feel free to ask for another QA. QA notes: I wasn't sure so I checked but the ORDER BY is indeed applied to the whole resultset and not only the last select of the union (https://mariadb.com/kb/en/union/#order-by-and-limit) Thanks Julian, I agree, all good for you're QA here. Shame it dropped through the queue and out of sight. :( Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.06 |