Summary: | Provide more info when using automatic authorities linking | ||
---|---|---|---|
Product: | Koha | Reporter: | Adolfo Rodríguez Taboada <adolfo.rodriguez> |
Component: | Cataloging | Assignee: | Adolfo Rodríguez Taboada <adolfo.rodriguez> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement adds more useful information to the automatic authority link results when editing a record and using "Link authorities automatically". It now includes the value you used for each authority entry (such as 650$a and $700$a), so you know which ones to look at. Previously, it only included the field number, such as 650, and not the term.
Example of new automatic authority link results:
- 650 - Biologie. - More than one local match found. Possibly a duplicate authority!
- 650 - Biology. - More than one local match found. Possibly a duplicate authority!
- 700 - Aristophanes. - More than one local match found. Possibly a duplicate authority!
- 700 - Beckett, Samuel, 1906-1989. - More than one local match found. Possibly a duplicate authority!
|
Version(s) released in: | |
Circulation function: | |||
Attachments: |
Fix - Bug 35452 - Provide more info when using Link authorities automatically
Fix - Bug 35452 - Provide more info when using Link authorities automatically Bug 35452: Provide more info when using Link authorities automatically |
Description
Adolfo Rodríguez Taboada
2023-11-30 12:34:29 UTC
Created attachment 159408 [details] [review] Fix - Bug 35452 - Provide more info when using Link authorities automatically Test plan 1 Edit a record and add several 7xx and 6xx 2 Click on Link authorities automatically and check that the result only shows the field numbers 3 Apply patch, restart services 4 Click on Link authorities automatically and check that the result shows the field numbers and the info of the entry Created attachment 159416 [details] [review] Fix - Bug 35452 - Provide more info when using Link authorities automatically Test plan 1 Edit a record and add several 7xx and 6xx 2 Click on Link authorities automatically and check that the result only shows the field numbers 3 Apply patch, restart services 4 Click on Link authorities automatically and check that the result shows the field numbers and the info of the entry Signed-off-by: David Nind <david@davidnind.com> This is a nice enhancement! I've added an assignee and some release notes. Testing notes (using koha-testing-docker (KTD)): 1. Paste these terms in new 650$a or 700$a fields for a record, instead of using the tag editor: - 650$a: Biologie. - 650$a: Biology. - 700$a: Aristophanes. - 700$a: Beckett, Samuel, 1906-1989. 2. After the patch is applied, you get a more useful message of where to look to fix things up: Automatic authority link results: - 650 - Biologie. - More than one local match found. Possibly a duplicate authority! - 650 - Biology. - More than one local match found. Possibly a duplicate authority! - 700 - Aristophanes. - More than one local match found. Possibly a duplicate authority! - 700 - Beckett, Samuel, 1906-1989. - More than one local match found. Possibly a duplicate authority! Created attachment 160590 [details] [review] Bug 35452: Provide more info when using Link authorities automatically Test plan 1 Edit a record and add several 7xx and 6xx 2 Click on Link authorities automatically and check that the result only shows the field numbers 3 Apply patch, restart services 4 Click on Link authorities automatically and check that the result shows the field numbers and the info of the entry Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> I am sorry, but this change breaks the unit tests, please provide a follow-up: prove t/Biblio.t t/db_dependent/Biblio.t t/Biblio.t ............... ok t/db_dependent/Biblio.t .. 11/20 # Failed test 'The heading was not linked' # at t/db_dependent/Biblio.t line 812. # Structures begin differing at: # $got->{data} = 'Duplicated' # $expected->{data} = Does not exist # Failed test 'When AutoCreateAuthorities is enabled, multiple results are reported' # at t/db_dependent/Biblio.t line 826. # Structures begin differing at: # $got->{data} = 'Duplicated' # $expected->{data} = Does not exist # Looks like you failed 2 tests of 5. I don't think this change is the one breaking that test as it only adds info in the result. It doesn't affect in the search of the authority. It should be the change made in the bug 31185. Before that change, link authorities automatically didn't detect duplicate authorities and the result you got in those case was that the authority wasn't found. I think it's exactly the discrepancy you are seeing in the test, as it expects "Does not exist" and gets "Duplicated" https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185 I think the bug 36938 covers the errors detected in the unit tests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36938 |