Summary: | Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | System Administration | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Status: | RESOLVED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, emily.lamancusa, fridolin.somers, gmcharlt, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/932 |
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
Circulation function: | |||
Bug Depends on: | 20755 | ||
Bug Blocks: | 36409 | ||
Attachments: |
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences |
Description
Katrin Fischer
2023-12-01 09:32:44 UTC
I was going to submit something, but I'm wondering if I should create a new subsection in the serials preferences? Right now, they are under Acquisitions > Policy. Serials only has the Feature subsection. I'm not sure it's part of Feature. Is Policy a good subsection name? Maybe Notices? Or Claims? Maybe "Notifications"? Created attachment 161543 [details] [review] Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences This patch moved the SerialsDefaultEMailAddress system preference and the SerialsDefaultReplyTo system preference to the Serials preferences. To test: 1. Apply patch 2. Go to Administration > System preferences > Acquisitions --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not be there 3. Go to Administration > System preferences > Serials --> There should be a new section called "Notifications" with the two system preferences Created attachment 161787 [details] [review] Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences This patch moved the SerialsDefaultEMailAddress system preference and the SerialsDefaultReplyTo system preference to the Serials preferences. To test: 1. Apply patch 2. Go to Administration > System preferences > Acquisitions --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not be there 3. Go to Administration > System preferences > Serials --> There should be a new section called "Notifications" with the two system preferences Signed-off-by: David Nind <david@davidnind.com> Changed assignee. Created attachment 163709 [details] [review] Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences This patch moved the SerialsDefaultEMailAddress system preference and the SerialsDefaultReplyTo system preference to the Serials preferences. To test: 1. Apply patch 2. Go to Administration > System preferences > Acquisitions --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not be there 3. Go to Administration > System preferences > Serials --> There should be a new section called "Notifications" with the two system preferences Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Looks good - passing QA! Out of scope for this bug, but shouldn't SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress have a lowercase m in Email? (In reply to Emily Lamancusa from comment #7) > Looks good - passing QA! > > Out of scope for this bug, but shouldn't SerialsDefaultEMailAddress and > AcquisitionsDefaultEMailAddress have a lowercase m in Email? Nice spotting! You are right - all other system preferences generally use ..Email... I've created bug 36409 to address the system preference naming consistency for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Missing 23.05.x dependencies, no backport. |