As noted by Caroline on bug 20755, we should move the 2 mentioned system preferences to the serials tab.
I was going to submit something, but I'm wondering if I should create a new subsection in the serials preferences? Right now, they are under Acquisitions > Policy. Serials only has the Feature subsection. I'm not sure it's part of Feature. Is Policy a good subsection name? Maybe Notices? Or Claims?
Maybe "Notifications"?
Created attachment 161543 [details] [review] Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences This patch moved the SerialsDefaultEMailAddress system preference and the SerialsDefaultReplyTo system preference to the Serials preferences. To test: 1. Apply patch 2. Go to Administration > System preferences > Acquisitions --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not be there 3. Go to Administration > System preferences > Serials --> There should be a new section called "Notifications" with the two system preferences
Created attachment 161787 [details] [review] Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences This patch moved the SerialsDefaultEMailAddress system preference and the SerialsDefaultReplyTo system preference to the Serials preferences. To test: 1. Apply patch 2. Go to Administration > System preferences > Acquisitions --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not be there 3. Go to Administration > System preferences > Serials --> There should be a new section called "Notifications" with the two system preferences Signed-off-by: David Nind <david@davidnind.com>
Changed assignee.
Created attachment 163709 [details] [review] Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences This patch moved the SerialsDefaultEMailAddress system preference and the SerialsDefaultReplyTo system preference to the Serials preferences. To test: 1. Apply patch 2. Go to Administration > System preferences > Acquisitions --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not be there 3. Go to Administration > System preferences > Serials --> There should be a new section called "Notifications" with the two system preferences Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Looks good - passing QA! Out of scope for this bug, but shouldn't SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress have a lowercase m in Email?
(In reply to Emily Lamancusa from comment #7) > Looks good - passing QA! > > Out of scope for this bug, but shouldn't SerialsDefaultEMailAddress and > AcquisitionsDefaultEMailAddress have a lowercase m in Email? Nice spotting! You are right - all other system preferences generally use ..Email...
I've created bug 36409 to address the system preference naming consistency for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress.
Pushed for 24.05! Well done everyone, thank you!