Bug 35457 - Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences
Summary: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Emily Lamancusa
URL:
Keywords: Academy
Depends on: 20755
Blocks: 36409
  Show dependency treegraph
 
Reported: 2023-12-01 09:32 UTC by Katrin Fischer
Modified: 2024-03-25 08:54 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences (4.58 KB, patch)
2024-01-26 14:57 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences (4.63 KB, patch)
2024-02-06 16:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences (4.70 KB, patch)
2024-03-22 14:39 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-12-01 09:32:44 UTC
As noted by Caroline on bug 20755, we should move the 2 mentioned system preferences to the serials tab.
Comment 1 Caroline Cyr La Rose 2024-01-25 15:51:46 UTC
I was going to submit something, but I'm wondering if I should create a new subsection in the serials preferences? Right now, they are under Acquisitions > Policy. Serials only has the Feature subsection. I'm not sure it's part of Feature. Is Policy a good subsection name? Maybe Notices? Or Claims?
Comment 2 Katrin Fischer 2024-01-25 21:48:24 UTC
Maybe "Notifications"?
Comment 3 Caroline Cyr La Rose 2024-01-26 14:57:22 UTC
Created attachment 161543 [details] [review]
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences

This patch moved the SerialsDefaultEMailAddress system preference and
the SerialsDefaultReplyTo system preference to the Serials preferences.

To test:
1. Apply patch
2. Go to Administration > System preferences > Acquisitions
   --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not
   be there
3. Go to Administration > System preferences > Serials
   --> There should be a new section called "Notifications" with
   the two system preferences
Comment 4 David Nind 2024-02-06 16:41:17 UTC
Created attachment 161787 [details] [review]
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences

This patch moved the SerialsDefaultEMailAddress system preference and
the SerialsDefaultReplyTo system preference to the Serials preferences.

To test:
1. Apply patch
2. Go to Administration > System preferences > Acquisitions
   --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not
   be there
3. Go to Administration > System preferences > Serials
   --> There should be a new section called "Notifications" with
   the two system preferences

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2024-02-06 16:43:01 UTC
Changed assignee.
Comment 6 Emily Lamancusa 2024-03-22 14:39:00 UTC
Created attachment 163709 [details] [review]
Bug 35457: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences

This patch moved the SerialsDefaultEMailAddress system preference and
the SerialsDefaultReplyTo system preference to the Serials preferences.

To test:
1. Apply patch
2. Go to Administration > System preferences > Acquisitions
   --> SerialsDefaultEMailAddress and SerialsDefaultReplyTo should not
   be there
3. Go to Administration > System preferences > Serials
   --> There should be a new section called "Notifications" with
   the two system preferences

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 7 Emily Lamancusa 2024-03-22 15:06:30 UTC
Looks good - passing QA!

Out of scope for this bug, but shouldn't SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress have a lowercase m in Email?
Comment 8 David Nind 2024-03-22 16:28:56 UTC
(In reply to Emily Lamancusa from comment #7)
> Looks good - passing QA!
> 
> Out of scope for this bug, but shouldn't SerialsDefaultEMailAddress and
> AcquisitionsDefaultEMailAddress have a lowercase m in Email?

Nice spotting! You are right - all other system preferences generally use ..Email...
Comment 9 David Nind 2024-03-23 00:19:38 UTC
I've created bug 36409 to address the system preference naming consistency for SerialsDefaultEMailAddress and AcquisitionsDefaultEMailAddress.
Comment 10 Katrin Fischer 2024-03-25 08:54:21 UTC
Pushed for 24.05!

Well done everyone, thank you!