Description
Lucas Gass (lukeg)
2023-12-01 16:33:21 UTC
Created attachment 185119 [details] [review] Bug 35467: Rename NewsLog system preference to AdditionalContent To test: 1 - confirm whether or not NewsLog is enabled on your system 2 - apply patch, updatedatabase, restart_all 3 - search system preferences, confirm you now have AdditionalContentLog rather than NewsLog and that the new description is accurate 4 - confitm AdditionalContentLog shows the value you previously had for NewsLog 5 - go to Tools > Log Viewer 6 - confirm the checkbox here is labeled "Additional Content", that it correctly reflects the syspref value, and that it links to the syspref 7 - with AdditionalContentLog enabled, created/edit/delete news, HTML customizations, and pages. confirm they log 8 - with AdditionalContentLog disabled, created/edit/delete news, HTML customizations, and pages. confirm they don't log Created attachment 185120 [details] [review] Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog Created attachment 185122 [details] [review] Bug 35467: Rename NewsLog system preference to AdditionalContent To test: 1 - confirm whether or not NewsLog is enabled on your system 2 - apply patch, updatedatabase, restart_all 3 - search system preferences, confirm you now have AdditionalContentLog rather than NewsLog and that the new description is accurate 4 - confitm AdditionalContentLog shows the value you previously had for NewsLog 5 - go to Tools > Log Viewer 6 - confirm the checkbox here is labeled "Additional Content", that it correctly reflects the syspref value, and that it links to the syspref 7 - with AdditionalContentLog enabled, created/edit/delete news, HTML customizations, and pages. confirm they log 8 - with AdditionalContentLog disabled, created/edit/delete news, HTML customizations, and pages. confirm they don't log Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 185123 [details] [review] Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog Signed-off-by: Owen Leonard <oleonard@myacpl.org> 1) QA script not happy: [FAIL] installer/data/mysql/atomicupdate/bug_35467_AdditionalContentLog.pl FAIL file_permissions File must have the exec flag 2) Typo here: changes to HTML customizations, news entires, news entries* 3) Minor observation: Should we call it AdditionalContentsLog (plural)? (In reply to Pedro Amorim from comment #5) > 3) Minor observation: Should we call it AdditionalContentsLog (plural)? I wondered about this. In the staff interface, if you go to any of these tools the page says "Additional content: Pages" or "Additional content: News." So I followed that, but don't have strong feelings. Created attachment 185127 [details] [review] Bug 35467: atomicupdate to rename NewsLog to AdditionalContentLog Now executable! Created attachment 185128 [details] [review] Bug 35467L (QA followup): Spelling correction in syspref Created attachment 185129 [details] [review] Bug 35467: Rename NewsLog system preference to AdditionalContent To test: 1 - confirm whether or not NewsLog is enabled on your system 2 - apply patch, updatedatabase, restart_all 3 - search system preferences, confirm you now have AdditionalContentLog rather than NewsLog and that the new description is accurate 4 - confitm AdditionalContentLog shows the value you previously had for NewsLog 5 - go to Tools > Log Viewer 6 - confirm the checkbox here is labeled "Additional Content", that it correctly reflects the syspref value, and that it links to the syspref 7 - with AdditionalContentLog enabled, created/edit/delete news, HTML customizations, and pages. confirm they log 8 - with AdditionalContentLog disabled, created/edit/delete news, HTML customizations, and pages. confirm they don't log Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Created attachment 185130 [details] [review] Bug 35467: atomicupdate to change NewsLog to AdditionalContentLog Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Created attachment 185131 [details] [review] Bug 35467: atomicupdate to rename NewsLog to AdditionalContentLog Now executable! Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Created attachment 185132 [details] [review] Bug 35467: (QA follow-up): Spelling correction in syspref PA amendded: Commit title Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> Nice work everyone! Pushed to main for 25.11 |