Bug 35540

Summary: Separate StaffListsHome block from the table block
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: Staff interfaceAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Bug Depends on: 6419    
Bug Blocks:    
Attachments: Bug 35540: Separate StaffListsHome block from the table block
Bug 35540: Separate StaffListsHome block from the table block
Bug 35540: Separate StaffListsHome block from the table block

Description Caroline Cyr La Rose 2023-12-11 16:57:31 UTC
This is very minor, but I thought I'd mention it. I noticed that most of the new staff interface additional content blocks are in their own white "block" on the page they are on with a space between the normal content and it (I hope that sentence makes sense...).

In the case of StaffListsHome, the white block is right under the lists page main content, with no space.

To recreate:
1. Go to Tools > HTML customizations
2. Click New entry
3. Fill out the form:
   -  Display location: StaffListsHome
   -  Publication date: any date before today
   -  Title: StaffListsHome (or whatever)
   -  Content: StaffListsHome (or whatever)
4. Click Save
5. Go to Lists
   --> Note that there is no space between the 'StaffListsHome' white background and the white background of the Your lists table.

To compare:
1. Go to Tools > HTML customizations
2. Click New entry
3. Fill out the form:
   -  Display location: StaffAcquisitionsHome
   -  Publication date: any date before today
   -  Title: StaffAcquisitionsHome (or whatever)
   -  Content: StaffAcquisitionsHome (or whatever)
4. Click Save
5. Go to Acquisitions
   --> Note that there is a clear space between the 'StaffAcquisitionsHome' white background and the white background of the budgets table.
Comment 1 Caroline Cyr La Rose 2023-12-11 17:07:21 UTC
I just noticed the StaffPatronsHome has the same problem.
Comment 2 Owen Leonard 2023-12-18 18:49:29 UTC
Created attachment 159977 [details] [review]
Bug 35540: Separate StaffListsHome block from the table block

This patch makes some minor changes to template markup and CSS so that
"page-section" divs have consistent margins.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Tools -> HTML customizations and create a new entry in
  StaffListsHome, StaffPatronsHome, and StaffPOSHome regions.
- Confirm that those customizations are displayed well on each of those
  corresponding pages: The lists home page, the patrons home page, and
  the Point of Sale home page.
- Confirm that other pages affected by the CSS change still display
  correctly. These pages have an added bottom margin on the main
  "container" of content. For example:
  - Patrons -> Patron search results
  - Catalog -> Catalog search results (especially results with multiple
    pages)
  - Circulation -> Circulation history
  - Reports -> Saved SQL reports
Comment 3 Caroline Cyr La Rose 2023-12-18 19:14:25 UTC
Created attachment 159980 [details] [review]
Bug 35540: Separate StaffListsHome block from the table block

This patch makes some minor changes to template markup and CSS so that
"page-section" divs have consistent margins.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Tools -> HTML customizations and create a new entry in
  StaffListsHome, StaffPatronsHome, and StaffPOSHome regions.
- Confirm that those customizations are displayed well on each of those
  corresponding pages: The lists home page, the patrons home page, and
  the Point of Sale home page.
- Confirm that other pages affected by the CSS change still display
  correctly. These pages have an added bottom margin on the main
  "container" of content. For example:
  - Patrons -> Patron search results
  - Catalog -> Catalog search results (especially results with multiple
    pages)
  - Circulation -> Circulation history
  - Reports -> Saved SQL reports

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 4 Jonathan Druart 2024-01-12 10:59:58 UTC
Created attachment 160929 [details] [review]
Bug 35540: Separate StaffListsHome block from the table block

This patch makes some minor changes to template markup and CSS so that
"page-section" divs have consistent margins.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Tools -> HTML customizations and create a new entry in
  StaffListsHome, StaffPatronsHome, and StaffPOSHome regions.
- Confirm that those customizations are displayed well on each of those
  corresponding pages: The lists home page, the patrons home page, and
  the Point of Sale home page.
- Confirm that other pages affected by the CSS change still display
  correctly. These pages have an added bottom margin on the main
  "container" of content. For example:
  - Patrons -> Patron search results
  - Catalog -> Catalog search results (especially results with multiple
    pages)
  - Circulation -> Circulation history
  - Reports -> Saved SQL reports

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Katrin Fischer 2024-03-22 09:37:12 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-22 14:02:00 UTC
Not backported to 23.11.x
Comment 7 Caroline Cyr La Rose 2024-07-09 20:54:06 UTC
Nothing to add/edit in the Koha manual that I can see.