It would be great if you could edit module pages (serials, acq, cataloging, etc) and add links to the reports you've written that are related to those pages - or a way to have them automatically appear on those pages.
We now got IntranetCirculationHomeHTML and IntranetReportsHomeHTML that allow to add custom content to the circulation and reports start pages.
Picking this up as it has been dormant for nearly a decade, and it's pretty straightforward. I'm adding customisable content areas to the acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages which all link from the intranet home page. I will use the same method of implementing this as in Bug 15008, so it will look and behave exactly like the existing IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences.
Created attachment 105255 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences.
At this point I think it would be better to add these HTML content areas to the News editor instead of adding new system preferences for each?
Created attachment 108633 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
Hi David, there are some issues here: 1) QA test tools There are some missing filters the QA tools complain about (excuse the bad formatting): FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt FAIL filters missing_filter at line 269 ( [% Koha.Preference('IntranetAcquisitionsHomeHTML') %]) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tt FAIL filters missing_filter at line 30 ( [% Koha.Preference('IntranetAuthoritiesHomeHTML') %]) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt FAIL filters missing_filter at line 302 ( [% Koha.Preference('IntranetCatalogingHomeHTML') %]) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt FAIL filters missing_filter at line 517 ( [% Koha.Preference('IntranetPatronsHomeHTML') %]) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt FAIL filters missing_filter at line 403 ( [% Koha.Preference('IntranetPOSHomeHTML') %]) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt FAIL filters missing_filter at line 45 ( [% Koha.Preference('IntranetSerialsHomeHTML') %]) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt FAIL filters missing_filter at line 772 ( [% Koha.Preference('IntranetListsHomeHTML') %]) I think we probably needs a $raw here, as we expect the content to be HTML I am adding Owen to see if he is planning to move the intranet related content prefs to the news editor as well.
Created attachment 137787 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
Rebased and fixed QA issues. Probably worth a retest as the templates have changed significantly since this was first written. I still think it's a worthwhile little enhancement though :) Regarding it still using system preferences, I felt that was the simplest route to goal for now.. we can always move them later I feel.
Created attachment 137822 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Signed-off-by: Daniel <daniel.jones@cheshiresharedservices.gov.uk>
Works as described- good enhancement.
It would have been nice to provide something generic and flexible. We could have offered a way to add additional content to any pages in Koha. With an editor, a list of pages, then we can inject the content to the correct body.
The solution suggested here is to have 1 syspref per page.
Created attachment 139501 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Signed-off-by: Daniel <daniel.jones@cheshiresharedservices.gov.uk> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Can we move this (at least) to the AdditionalContents schema?
Yeah, I rebased it, but I also think perhaps it should be done using more modern options.
Moving to failed QA on the consensus that this should not be moved into HTML customizations.
(In reply to Katrin Fischer from comment #16) > Moving to failed QA on the consensus that this should not be moved into HTML > customizations. We might want to re-think that. These sysprefs have security problems which will be better addressed in Additional Contents/HTML Customizations.
(In reply to David Cook from comment #17) > (In reply to Katrin Fischer from comment #16) > > Moving to failed QA on the consensus that this should not be moved into HTML > > customizations. > > We might want to re-think that. These sysprefs have security problems which > will be better addressed in Additional Contents/HTML Customizations. Sorry, typo on my part: SHOULD BE moved into HTML customizations.
(In reply to Katrin Fischer from comment #18) > Sorry, typo on my part: SHOULD BE moved into HTML customizations. Ahhh all good then! Thanks for clarifying :)
Created attachment 154433 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
Created attachment 154434 [details] [review] Bug 6419: Add IntranetAcquisitionsHome block to additional contents This patch adds a new `IntranetAcquisitionsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the acquisitions home page.
Created attachment 154435 [details] [review] Bug 6419: Add IntranetAuthoritiesHome block to additional contents This patch adds a new `IntranetAuthoritiesHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the authorities home page.
Created attachment 154436 [details] [review] Bug 6419: Add IntranetCataloguingHome block to additional contents This patch adds a new `IntranetCataloguingHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the cataloguing home page.
I've started the conversion.. if someone fancies taking a look at the outstanding ones that would be awesome.. I've been converting from the ones added in the original patch one per patch so we can track them easily.
Created attachment 154437 [details] [review] Bug 6419: Add IntranetListsHome block to additional contents This patch adds a new `IntranetListsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the lists home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections.
Created attachment 154441 [details] [review] Bug 6419: Add IntranetPatronsHome block to additional contents This patch adds a new `IntranetPatronsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the patrons home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections.
Created attachment 154442 [details] [review] Bug 6419: Add IntranetPOSHome block to additional contents This patch adds a new `IntranetPOSHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: All the blocks have been placed at the bottom of the home pages respectively for consistency. However, in this case it doesn't look as clean as the content above is a form.
Created attachment 154443 [details] [review] Bug 6419: Add IntranetSerialsHome block to additional contents This patch adds a new `IntranetSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series.
I would like to use another term besides "Intranet" since we've been trying to get away from that word for a while. I would think "Staff" would be clear enough to distinguish these options from the ones which are for the OPAC
That's a good call Owen.. I can do that. I've not migrated any existing preferences here yet either.. but I'd like to. I'd also love to see these contents blocks work a little differently from News with regards dates.. it's a bit silly to require a publication date for these blocks that are much more likely to just be static.
Created attachment 154444 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
Created attachment 154445 [details] [review] Bug 6419: Add StaffAcquisitionsHome block to additional contents This patch adds a new `StaffAcquisitionsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the acquisitions home page.
Created attachment 154446 [details] [review] Bug 6419: Add StaffAuthoritiesHome block to additional contents This patch adds a new `StaffAuthoritiesHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the authorities home page.
Created attachment 154447 [details] [review] Bug 6419: Add StaffCataloguingHome block to additional contents This patch adds a new `StaffCataloguingHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the cataloguing home page.
Created attachment 154448 [details] [review] Bug 6419: Add StaffListsHome block to additional contents This patch adds a new `StaffListsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the lists home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections.
Created attachment 154449 [details] [review] Bug 6419: Add StaffPatronsHome block to additional contents This patch adds a new `StaffPatronsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the patrons home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections.
Created attachment 154450 [details] [review] Bug 6419: Add StaffPOSHome block to additional contents This patch adds a new `StaffPOSHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: All the blocks have been placed at the bottom of the home pages respectively for consistency. However, in this case it doesn't look as clean as the content above is a form.
Created attachment 154451 [details] [review] Bug 6419: Add StaffSerialsHome block to additional contents This patch adds a new `StaffSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series.
Done the switch to 'Staff' now.. just the migrations of the old preference based ones that pre-exist this patchset now.. should we do that here or in a follow-up bug?
Created attachment 154452 [details] [review] Bug 6419: (follow-up) Use Select2 with optgroups This patch divides the OPAC and staff options into separate optgroups and adds Select2 for styling and filtering. THe patch also corrects a few missed instances of "Intranet" in the list of location options on the entry form.
Created attachment 154519 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 154520 [details] [review] Bug 6419: Add StaffAcquisitionsHome block to additional contents This patch adds a new `StaffAcquisitionsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the acquisitions home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 154521 [details] [review] Bug 6419: Add StaffAuthoritiesHome block to additional contents This patch adds a new `StaffAuthoritiesHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the authorities home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 154522 [details] [review] Bug 6419: Add StaffCataloguingHome block to additional contents This patch adds a new `StaffCataloguingHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the cataloguing home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 154523 [details] [review] Bug 6419: Add StaffListsHome block to additional contents This patch adds a new `StaffListsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the lists home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 154524 [details] [review] Bug 6419: Add StaffPatronsHome block to additional contents This patch adds a new `StaffPatronsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the patrons home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 154525 [details] [review] Bug 6419: Add StaffPOSHome block to additional contents This patch adds a new `StaffPOSHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: All the blocks have been placed at the bottom of the home pages respectively for consistency. However, in this case it doesn't look as clean as the content above is a form. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 154526 [details] [review] Bug 6419: Add StaffSerialsHome block to additional contents This patch adds a new `StaffSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 154527 [details] [review] Bug 6419: (follow-up) Use Select2 with optgroups This patch divides the OPAC and staff options into separate optgroups and adds Select2 for styling and filtering. THe patch also corrects a few missed instances of "Intranet" in the list of location options on the entry form. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
This is really cool. Thanks Martin!
I love the follow-up, thanks for that Owen. Thanks for the testing Caroline, really happy to see this one start moving forward again.. David will be pleased too :)
*** Bug 14835 has been marked as a duplicate of this bug. ***
I still think we need something more generic here. At the very least it should be only 1 line in the template, at the correct place: [% AdditionalContents.GetSection(ID) %]
Created attachment 155808 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155809 [details] [review] Bug 6419: Add StaffAcquisitionsHome block to additional contents This patch adds a new `StaffAcquisitionsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the acquisitions home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155810 [details] [review] Bug 6419: Add StaffAuthoritiesHome block to additional contents This patch adds a new `StaffAuthoritiesHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the authorities home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155811 [details] [review] Bug 6419: Add StaffCataloguingHome block to additional contents This patch adds a new `StaffCataloguingHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the cataloguing home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155812 [details] [review] Bug 6419: Add StaffListsHome block to additional contents This patch adds a new `StaffListsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the lists home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155813 [details] [review] Bug 6419: Add StaffPatronsHome block to additional contents This patch adds a new `StaffPatronsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the patrons home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155814 [details] [review] Bug 6419: Add StaffPOSHome block to additional contents This patch adds a new `StaffPOSHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: All the blocks have been placed at the bottom of the home pages respectively for consistency. However, in this case it doesn't look as clean as the content above is a form. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155815 [details] [review] Bug 6419: Add StaffSerialsHome block to additional contents This patch adds a new `StaffSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 155816 [details] [review] Bug 6419: (follow-up) Use Select2 with optgroups This patch divides the OPAC and staff options into separate optgroups and adds Select2 for styling and filtering. THe patch also corrects a few missed instances of "Intranet" in the list of location options on the entry form. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Rebased.
This is looking good. DB updates look good, each of the new HTML areas works nice and produces valid HTML. QA script is happy. Great enhancement.
Created attachment 155839 [details] [review] Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 155840 [details] [review] Bug 6419: Add StaffAcquisitionsHome block to additional contents This patch adds a new `StaffAcquisitionsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the acquisitions home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 155841 [details] [review] Bug 6419: Add StaffAuthoritiesHome block to additional contents This patch adds a new `StaffAuthoritiesHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the authorities home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 155842 [details] [review] Bug 6419: Add StaffCataloguingHome block to additional contents This patch adds a new `StaffCataloguingHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the cataloguing home page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 155843 [details] [review] Bug 6419: Add StaffListsHome block to additional contents This patch adds a new `StaffListsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the lists home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 155844 [details] [review] Bug 6419: Add StaffPatronsHome block to additional contents This patch adds a new `StaffPatronsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the patrons home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 155845 [details] [review] Bug 6419: Add StaffPOSHome block to additional contents This patch adds a new `StaffPOSHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: All the blocks have been placed at the bottom of the home pages respectively for consistency. However, in this case it doesn't look as clean as the content above is a form. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 155846 [details] [review] Bug 6419: Add StaffSerialsHome block to additional contents This patch adds a new `StaffSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 155847 [details] [review] Bug 6419: (follow-up) Use Select2 with optgroups This patch divides the OPAC and staff options into separate optgroups and adds Select2 for styling and filtering. THe patch also corrects a few missed instances of "Intranet" in the list of location options on the entry form. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(In reply to Lucas Gass from comment #64) > This is looking good. DB updates look good, each of the new HTML areas works > nice and produces valid HTML. QA script is happy. Great enhancement. What about comment 53?
I missed that comment entirely I'm afraid. I don't really have any spare time to work on further follow-ups.. can we record that request as a new bug and I'll try to take care of it when I have some more time available again..
(In reply to Jonathan Druart from comment #74) > (In reply to Lucas Gass from comment #64) > > This is looking good. DB updates look good, each of the new HTML areas works > > nice and produces valid HTML. QA script is happy. Great enhancement. > > What about comment 53? I agree. This is one of the bottlenecks when using AC in development / customization. You should be able to define your own named blocks. This is reported already in some way or the other. We should prevent to have a very long list of names in the AC popup in the end. Maybe make a difference between 'system' entries and other ones? But I dont think that the need for a more generic approach is a blocker for this one. We did not define a temporary coding guideline to block adding more entries :)
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x