Bug 6419 - Add customizable areas to intranet home pages
Summary: Add customizable areas to intranet home pages
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Lucas Gass
URL:
Keywords:
: 14835 (view as bug list)
Depends on: 31162
Blocks: 35116 35540
  Show dependency treegraph
 
Reported: 2011-05-27 18:52 UTC by Nicole C. Engard
Modified: 2023-12-11 21:03 UTC (History)
18 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/777
Text to go in the release notes:
This enhancement adds several new locations to HTML customizations to add content to various staff interface pages. This supports multilingual content, as with any HTML customization. New locations are: - StaffAcquisitionsHome: adds content at the bottom of the acquisitions module home page - StaffAuthoritiesHome: adds content at the bottom of the authorities module home page - StaffCataloguingHome: adds content at the bottom of the cataloguing module home page - StaffListsHome: adds content at the bottom of the lists module home page - StaffPatronsHome: adds content at the bottom of the patrons module home page - StaffPOSHome: adds content at the bottom of the point of sale module home page - StaffSerialsHome: adds content at the bottom of the serials module home page
Version(s) released in:
23.11.00


Attachments
Bug 6419: Add custom HTML areas to intranet home pages (13.46 KB, patch)
2020-05-22 09:39 UTC, David Roberts
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (13.44 KB, patch)
2020-08-19 13:59 UTC, Brandon J
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (15.64 KB, patch)
2022-07-15 17:03 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (15.71 KB, patch)
2022-07-18 14:59 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (15.81 KB, patch)
2022-08-19 15:05 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (15.64 KB, patch)
2023-08-15 15:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add IntranetAcquisitionsHome block to additional contents (7.74 KB, patch)
2023-08-15 15:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add IntranetAuthoritiesHome block to additional contents (8.57 KB, patch)
2023-08-15 15:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add IntranetCataloguingHome block to additional contents (8.03 KB, patch)
2023-08-15 15:04 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add IntranetListsHome block to additional contents (7.55 KB, patch)
2023-08-15 15:37 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add IntranetPatronsHome block to additional contents (7.00 KB, patch)
2023-08-16 06:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add IntranetPOSHome block to additional contents (6.75 KB, patch)
2023-08-16 06:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add IntranetSerialsHome block to additional contents (7.07 KB, patch)
2023-08-16 06:51 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (15.64 KB, patch)
2023-08-16 07:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add StaffAcquisitionsHome block to additional contents (7.72 KB, patch)
2023-08-16 07:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add StaffAuthoritiesHome block to additional contents (8.54 KB, patch)
2023-08-16 07:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add StaffCataloguingHome block to additional contents (8.00 KB, patch)
2023-08-16 07:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add StaffListsHome block to additional contents (7.52 KB, patch)
2023-08-16 07:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add StaffPatronsHome block to additional contents (6.97 KB, patch)
2023-08-16 07:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add StaffPOSHome block to additional contents (6.72 KB, patch)
2023-08-16 07:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: Add StaffSerialsHome block to additional contents (7.04 KB, patch)
2023-08-16 07:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 6419: (follow-up) Use Select2 with optgroups (3.55 KB, patch)
2023-08-16 08:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (15.73 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: Add StaffAcquisitionsHome block to additional contents (7.80 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: Add StaffAuthoritiesHome block to additional contents (8.62 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: Add StaffCataloguingHome block to additional contents (8.08 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: Add StaffListsHome block to additional contents (7.60 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: Add StaffPatronsHome block to additional contents (7.05 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: Add StaffPOSHome block to additional contents (6.80 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: Add StaffSerialsHome block to additional contents (7.11 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: (follow-up) Use Select2 with optgroups (3.62 KB, patch)
2023-08-17 10:31 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (15.70 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add StaffAcquisitionsHome block to additional contents (7.87 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add StaffAuthoritiesHome block to additional contents (8.70 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add StaffCataloguingHome block to additional contents (8.15 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add StaffListsHome block to additional contents (7.67 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add StaffPatronsHome block to additional contents (7.12 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add StaffPOSHome block to additional contents (6.86 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add StaffSerialsHome block to additional contents (7.16 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: (follow-up) Use Select2 with optgroups (3.69 KB, patch)
2023-09-18 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6419: Add custom HTML areas to intranet home pages (15.76 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 6419: Add StaffAcquisitionsHome block to additional contents (7.93 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 6419: Add StaffAuthoritiesHome block to additional contents (8.75 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 6419: Add StaffCataloguingHome block to additional contents (8.21 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 6419: Add StaffListsHome block to additional contents (7.72 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 6419: Add StaffPatronsHome block to additional contents (7.17 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 6419: Add StaffPOSHome block to additional contents (6.91 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 6419: Add StaffSerialsHome block to additional contents (7.22 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 6419: (follow-up) Use Select2 with optgroups (3.75 KB, patch)
2023-09-18 16:14 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-05-27 18:52:29 UTC
It would be great if you could edit module pages (serials, acq, cataloging, etc) and add links to the reports you've written that are related to those pages - or a way to have them automatically appear on those pages.
Comment 1 Katrin Fischer 2016-06-19 22:57:58 UTC
We now got IntranetCirculationHomeHTML and IntranetReportsHomeHTML that allow to add custom content to the circulation and reports start pages.
Comment 2 David Roberts 2020-05-21 23:38:40 UTC
Picking this up as it has been dormant for nearly a decade, and it's pretty straightforward. I'm adding customisable content areas to the acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages which all link from the intranet home page. I will use the same method of implementing this as in Bug 15008, so it will look and behave exactly like the existing IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences.
Comment 3 David Roberts 2020-05-22 09:39:10 UTC
Created attachment 105255 [details] [review]
Bug 6419: Add custom HTML areas to intranet home pages

This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages

To test:

1) Apply patch
2) Run updatedatabase.pl
3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML
4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences.
Comment 4 Lucas Gass 2020-05-22 21:49:13 UTC
At this point I think it would be better to add these HTML content areas to the News editor instead of adding new system preferences for each?
Comment 5 Brandon J 2020-08-19 13:59:15 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2020-08-22 13:26:16 UTC
Hi David,

there are some issues here:

1) QA test tools 

There are some missing filters the QA tools complain about (excuse the bad formatting):

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
   FAIL	  filters
		missing_filter at line 269 (        [% Koha.Preference('IntranetAcquisitionsHomeHTML') %])

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities-home.tt
   FAIL	  filters
		missing_filter at line 30 (        [% Koha.Preference('IntranetAuthoritiesHomeHTML') %])

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt
   FAIL	  filters
		missing_filter at line 302 (        [% Koha.Preference('IntranetCatalogingHomeHTML') %])

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
   FAIL	  filters
		missing_filter at line 517 (        [% Koha.Preference('IntranetPatronsHomeHTML') %])

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
   FAIL	  filters
		missing_filter at line 403 (        [% Koha.Preference('IntranetPOSHomeHTML') %])

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt
   FAIL	  filters
		missing_filter at line 45 (        [% Koha.Preference('IntranetSerialsHomeHTML') %])


 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
   FAIL	  filters
		missing_filter at line 772 (        [% Koha.Preference('IntranetListsHomeHTML') %])

I think we probably needs a $raw here, as we expect the content to be HTML

I am adding Owen to see if he is planning to move the intranet related content prefs to the news editor as well.
Comment 7 Martin Renvoize 2022-07-15 17:03:19 UTC Comment hidden (obsolete)
Comment 8 Martin Renvoize 2022-07-15 17:04:43 UTC
Rebased and fixed QA issues.

Probably worth a retest as the templates have changed significantly since this was first written.

I still think it's a worthwhile little enhancement though :)

Regarding it still using system preferences, I felt that was the simplest route to goal for now.. we can always move them later I feel.
Comment 9 Biblibre Sandboxes 2022-07-18 14:59:32 UTC Comment hidden (obsolete)
Comment 10 Daniel Jones 2022-07-18 15:01:16 UTC
Works as described- good enhancement.
Comment 11 Jonathan Druart 2022-08-09 10:10:26 UTC
It would have been nice to provide something generic and flexible. We could have offered a way to add additional content to any pages in Koha.

With an editor, a list of pages, then we can inject the content to the correct body.
Comment 12 Jonathan Druart 2022-08-09 10:11:08 UTC
The solution suggested here is to have 1 syspref per page.
Comment 13 Kyle M Hall 2022-08-19 15:05:36 UTC Comment hidden (obsolete)
Comment 14 Tomás Cohen Arazi 2022-09-12 20:11:26 UTC
Can we move this (at least) to the AdditionalContents schema?
Comment 15 Martin Renvoize 2022-09-13 12:49:08 UTC
Yeah, I rebased it, but I also think perhaps it should be done using more modern options.
Comment 16 Katrin Fischer 2023-08-04 20:44:35 UTC
Moving to failed QA on the consensus that this should not be moved into HTML customizations.
Comment 17 David Cook 2023-08-06 23:18:57 UTC
(In reply to Katrin Fischer from comment #16)
> Moving to failed QA on the consensus that this should not be moved into HTML
> customizations.

We might want to re-think that. These sysprefs have security problems which will be better addressed in Additional Contents/HTML Customizations.
Comment 18 Katrin Fischer 2023-08-07 07:47:59 UTC
(In reply to David Cook from comment #17)
> (In reply to Katrin Fischer from comment #16)
> > Moving to failed QA on the consensus that this should not be moved into HTML
> > customizations.
> 
> We might want to re-think that. These sysprefs have security problems which
> will be better addressed in Additional Contents/HTML Customizations.

Sorry, typo on my part: SHOULD BE moved into HTML customizations.
Comment 19 David Cook 2023-08-07 23:33:24 UTC
(In reply to Katrin Fischer from comment #18)
> Sorry, typo on my part: SHOULD BE moved into HTML customizations.

Ahhh all good then! Thanks for clarifying :)
Comment 20 Martin Renvoize 2023-08-15 15:04:32 UTC Comment hidden (obsolete)
Comment 21 Martin Renvoize 2023-08-15 15:04:35 UTC Comment hidden (obsolete)
Comment 22 Martin Renvoize 2023-08-15 15:04:38 UTC Comment hidden (obsolete)
Comment 23 Martin Renvoize 2023-08-15 15:04:41 UTC Comment hidden (obsolete)
Comment 24 Martin Renvoize 2023-08-15 15:07:14 UTC
I've started the conversion.. if someone fancies taking a look at the outstanding ones that would be awesome..  I've been converting from the ones added in the original patch one per patch so we can track them easily.
Comment 25 Martin Renvoize 2023-08-15 15:37:49 UTC Comment hidden (obsolete)
Comment 26 Martin Renvoize 2023-08-16 06:34:22 UTC Comment hidden (obsolete)
Comment 27 Martin Renvoize 2023-08-16 06:42:14 UTC Comment hidden (obsolete)
Comment 28 Martin Renvoize 2023-08-16 06:51:06 UTC Comment hidden (obsolete)
Comment 29 Owen Leonard 2023-08-16 07:03:44 UTC
I would like to use another term besides "Intranet" since we've been trying to get away from that word for a while. I would think "Staff" would be clear enough to distinguish these options from the ones which are for the OPAC
Comment 30 Martin Renvoize 2023-08-16 07:08:47 UTC
That's a good call Owen.. I can do that.

I've not migrated any existing preferences here yet either.. but I'd like to.  I'd also love to see these contents blocks work a little differently from News with regards dates.. it's a bit silly to require a publication date for these blocks that are much more likely to just be static.
Comment 31 Martin Renvoize 2023-08-16 07:34:07 UTC Comment hidden (obsolete)
Comment 32 Martin Renvoize 2023-08-16 07:34:10 UTC Comment hidden (obsolete)
Comment 33 Martin Renvoize 2023-08-16 07:34:13 UTC Comment hidden (obsolete)
Comment 34 Martin Renvoize 2023-08-16 07:34:17 UTC Comment hidden (obsolete)
Comment 35 Martin Renvoize 2023-08-16 07:34:20 UTC Comment hidden (obsolete)
Comment 36 Martin Renvoize 2023-08-16 07:34:23 UTC Comment hidden (obsolete)
Comment 37 Martin Renvoize 2023-08-16 07:34:26 UTC Comment hidden (obsolete)
Comment 38 Martin Renvoize 2023-08-16 07:34:29 UTC Comment hidden (obsolete)
Comment 39 Martin Renvoize 2023-08-16 07:38:21 UTC
Done the switch to 'Staff' now.. just the migrations of the old preference based ones that pre-exist this patchset now.. should we do that here or in a follow-up bug?
Comment 40 Owen Leonard 2023-08-16 08:24:39 UTC Comment hidden (obsolete)
Comment 41 Caroline Cyr La Rose 2023-08-17 10:31:03 UTC Comment hidden (obsolete)
Comment 42 Caroline Cyr La Rose 2023-08-17 10:31:07 UTC Comment hidden (obsolete)
Comment 43 Caroline Cyr La Rose 2023-08-17 10:31:11 UTC Comment hidden (obsolete)
Comment 44 Caroline Cyr La Rose 2023-08-17 10:31:15 UTC Comment hidden (obsolete)
Comment 45 Caroline Cyr La Rose 2023-08-17 10:31:19 UTC Comment hidden (obsolete)
Comment 46 Caroline Cyr La Rose 2023-08-17 10:31:23 UTC Comment hidden (obsolete)
Comment 47 Caroline Cyr La Rose 2023-08-17 10:31:27 UTC Comment hidden (obsolete)
Comment 48 Caroline Cyr La Rose 2023-08-17 10:31:31 UTC Comment hidden (obsolete)
Comment 49 Caroline Cyr La Rose 2023-08-17 10:31:35 UTC Comment hidden (obsolete)
Comment 50 Caroline Cyr La Rose 2023-08-17 10:33:41 UTC
This is really cool. Thanks Martin!
Comment 51 Martin Renvoize 2023-08-17 12:26:43 UTC
I love the follow-up, thanks for that Owen.  Thanks for the testing Caroline, really happy to see this one start moving forward again.. David will be pleased too :)
Comment 52 Katrin Fischer 2023-08-26 21:14:18 UTC
*** Bug 14835 has been marked as a duplicate of this bug. ***
Comment 53 Jonathan Druart 2023-08-30 13:29:24 UTC
I still think we need something more generic here.

At the very least it should be only 1 line in the template, at the correct place:

  [% AdditionalContents.GetSection(ID) %]
Comment 54 Owen Leonard 2023-09-18 12:48:10 UTC Comment hidden (obsolete)
Comment 55 Owen Leonard 2023-09-18 12:48:14 UTC Comment hidden (obsolete)
Comment 56 Owen Leonard 2023-09-18 12:48:17 UTC Comment hidden (obsolete)
Comment 57 Owen Leonard 2023-09-18 12:48:21 UTC Comment hidden (obsolete)
Comment 58 Owen Leonard 2023-09-18 12:48:24 UTC Comment hidden (obsolete)
Comment 59 Owen Leonard 2023-09-18 12:48:28 UTC Comment hidden (obsolete)
Comment 60 Owen Leonard 2023-09-18 12:48:31 UTC Comment hidden (obsolete)
Comment 61 Owen Leonard 2023-09-18 12:48:35 UTC Comment hidden (obsolete)
Comment 62 Owen Leonard 2023-09-18 12:48:38 UTC Comment hidden (obsolete)
Comment 63 Owen Leonard 2023-09-18 12:52:27 UTC
Rebased.
Comment 64 Lucas Gass 2023-09-18 16:12:46 UTC
This is looking good. DB updates look good, each of the new HTML areas works nice and produces valid HTML. QA script is happy. Great enhancement.
Comment 65 Lucas Gass 2023-09-18 16:14:02 UTC
Created attachment 155839 [details] [review]
Bug 6419: Add custom HTML areas to intranet home pages

This patch adds customisable HTML text areas to acqui/acqui-home.pl,
authorities/authorities-home.pl, cataloguing/addbooks.pl,
virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and
serials/serials-home.pl pages

To test:

1) Apply patch
2) Run updatedatabase.pl
3) Add some html to the new prefs IntranetAcquisitionsHomeHTML,
   IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML,
   IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML
   and IntranetSerialsHomeHTML
4) View the Acquisition, Authorities, Cataloging, Lists, Patrons,
   Point of Sale, and Serials homepages and confirm that your changes
   show. Note that this should display in exactly the same way as it
   does in the already extant IntranetCirculationHomeHTML and
   IntranetReportsHomeHTML system preferences.

Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 66 Lucas Gass 2023-09-18 16:14:07 UTC
Created attachment 155840 [details] [review]
Bug 6419: Add StaffAcquisitionsHome block to additional contents

This patch adds a new `StaffAcquisitionsHome` block to the HTML
Customisations options. This allows for the addition of a block of
content in a page-section at the bottom of the acquisitions home page.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 67 Lucas Gass 2023-09-18 16:14:11 UTC
Created attachment 155841 [details] [review]
Bug 6419: Add StaffAuthoritiesHome block to additional contents

This patch adds a new `StaffAuthoritiesHome` block to the HTML
Customisations options. This allows for the addition of a block of
content in a page-section at the bottom of the authorities home
page.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 68 Lucas Gass 2023-09-18 16:14:15 UTC
Created attachment 155842 [details] [review]
Bug 6419: Add StaffCataloguingHome block to additional contents

This patch adds a new `StaffCataloguingHome` block to the HTML
Customisations options. This allows for the addition of a block of
content in a page-section at the bottom of the cataloguing home
page.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 69 Lucas Gass 2023-09-18 16:14:20 UTC
Created attachment 155843 [details] [review]
Bug 6419: Add StaffListsHome block to additional contents

This patch adds a new `StaffListsHome` block to the HTML
Customisations options. This allows for the addition of a block of
content in a page-section at the bottom of the lists home
page.

NOTE: This one may highlight an issue with Panels directly followed by
page-sections.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 70 Lucas Gass 2023-09-18 16:14:24 UTC
Created attachment 155844 [details] [review]
Bug 6419: Add StaffPatronsHome block to additional contents

This patch adds a new `StaffPatronsHome` block to the HTML
Customisations options. This allows for the addition of a block of
content in a page-section at the bottom of the patrons home page.

NOTE: This one may highlight an issue with Panels directly followed
by page-sections.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 71 Lucas Gass 2023-09-18 16:14:28 UTC
Created attachment 155845 [details] [review]
Bug 6419: Add StaffPOSHome block to additional contents

This patch adds a new `StaffPOSHome` block to the HTML
Customisations options. This allows for the addition of a block of
content in a page-section at the bottom of the point of sale page.

NOTE: All the blocks have been placed at the bottom of the home pages
respectively for consistency. However, in this case it doesn't look as
clean as the content above is a form.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 72 Lucas Gass 2023-09-18 16:14:34 UTC
Created attachment 155846 [details] [review]
Bug 6419: Add StaffSerialsHome block to additional contents

This patch adds a new `StaffSerialsHome` block to the HTML
Customisations options. This allows for the addition of a block of
content in a page-section at the bottom of the point of sale page.

NOTE: This patch also removes the now defunct database update introduced
in the first patch of the series.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 73 Lucas Gass 2023-09-18 16:14:39 UTC
Created attachment 155847 [details] [review]
Bug 6419: (follow-up) Use Select2 with optgroups

This patch divides the OPAC and staff options into separate optgroups
and adds Select2 for styling and filtering.

THe patch also corrects a few missed instances of "Intranet" in the list
of location options on the entry form.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 74 Jonathan Druart 2023-09-18 16:29:04 UTC
(In reply to Lucas Gass from comment #64)
> This is looking good. DB updates look good, each of the new HTML areas works
> nice and produces valid HTML. QA script is happy. Great enhancement.

What about comment 53?
Comment 75 Martin Renvoize 2023-09-19 14:56:27 UTC
I missed that comment entirely I'm afraid.  I don't really have any spare time to work on further follow-ups.. can we record that request as a new bug and I'll try to take care of it when I have some more time available again..
Comment 76 Marcel de Rooy 2023-09-22 06:22:31 UTC
(In reply to Jonathan Druart from comment #74)
> (In reply to Lucas Gass from comment #64)
> > This is looking good. DB updates look good, each of the new HTML areas works
> > nice and produces valid HTML. QA script is happy. Great enhancement.
> 
> What about comment 53?

I agree. This is one of the bottlenecks when using AC in development / customization. You should be able to define your own named blocks. This is reported already in some way or the other.

We should prevent to have a very long list of names in the AC popup in the end.
Maybe make a difference between 'system' entries and other ones?

But I dont think that the need for a more generic approach is a blocker for this one. We did not define a temporary coding guideline to block adding more entries :)
Comment 77 Tomás Cohen Arazi 2023-10-18 18:43:44 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 78 Fridolin Somers 2023-10-25 08:00:08 UTC
Enhancement not pushed to 23.05.x