| Summary: | Authority search popup is only 700px | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Cataloging | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | anneli.osterman, barbara.petritsch, lucas, m.de.rooy, pedro.amorim, phan-tung.bui |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36143 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.04,23.05.10
|
|
| Circulation function: | |||
| Attachments: |
Bug 35554: Authority search popup width 800px
Bug 35554: Authority search popup width 800px Screenshot with patch Bug 35554: Authority search popup width 800px Bug 35554: Authority search popup width 800px |
||
Created attachment 159778 [details] [review] Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide After Applying the patch the value still doesn't change in the pop up window/Value builder of the field 700 a . Please can I get more instructions or if I did everything right the patch might not work. I had the same test results as Barbara in PTFS Europe's sandbox. Pop up doesn't get any wider. Created attachment 160640 [details] [review] Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide 4) Same with advanced editor (In reply to Anneli Österman from comment #3) > I had the same test results as Barbara in PTFS Europe's sandbox. Pop up > doesn't get any wider. Indeed ^^ Code to impact is in JS file, basic and advanced editors. Failed QA The authority search popup remains at a width of 700 pixels after the patch is applied. Failed QA The width of the popup remains 700px Created attachment 161387 [details]
Screenshot with patch
Here is how I see it with patch
Firefox inspector with mouse on body shows the size at top of the page
(In reply to Matthias Le Gac from comment #6) > Failed QA > > The authority search popup remains at a width of 700 pixels after the patch > is applied. (In reply to Phan Tung Bui from comment #7) > Failed QA > The width of the popup remains 700px Since this is a change in a javascript file, can you try clearing cache after applying patch (Ctrl+F5) ? Can you also try building koha-testing-docker with the patch ? Created attachment 162295 [details] [review] Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide 4) Same with advanced editor Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> git grep 'width=1000,height' | wc -l 35 git grep 'width=800,height' | wc -l 15 git grep 'width=700,height' | wc -l 27 I'm not sure about "most popups use 800 pixels", it seems there's no consistency whatsoever. I don't wish to block this bug but could we perhaps consider this opportunity to standardize these pop-up sizes across the code-base? In a different bug perhaps. Sure. Maybe define at least 2 standard sizes for example small/large. Size may depend on the content. Created attachment 162317 [details] [review] Bug 35554: Authority search popup width 800px Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one. Test plan : 1) Edit a biblio record 2) Click on value builder in a field linked to authority (ie 700) 3) Check popup is 800 pixels wide 4) Same with advanced editor Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.04 Backported to 23.05.x for upcoming 23.05.10 |
Authority search popup is only 700 pixels width. Most popups use 800 pixels, like the z3950 one : > git grep 'width=' koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: window.open(link+"&result="+defaultvalue,"valuebuilder",'width=700,height=550,toolbar=false,scrollbars=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=550,location=yes,toolbar=no,scrollbars=yes,resize=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes'); koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt: window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=[% biblionumber | html %]"+strQuery,"z3950search",'width=800,height=500,location=yes,toolbar=no,scrollbars=yes,resize=yes');