Bug 36143 - Pop-up window sizes are not consistent
Summary: Pop-up window sizes are not consistent
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-21 13:26 UTC by Pedro Amorim
Modified: 2024-02-23 15:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-02-21 13:26:12 UTC
It seems we have width+height specifically defined for each window.popup across the code base.
These are some of the variants I could find, but there may be others:
width=1000,height=600
width=1000,height=375
width=1000,height=575
width=900,height=700
width=800,height=400
width=800,height=550
width=800,height=500
width=700,height=700
width=700,height=600
width=700,height=400
width=700,height=550

This is not great, these should be standardized and configured once, example (values to be discussed):
large: 1000 x 600
medium: 800 x 500
small: 700 x 400
Comment 1 Fridolin Somers 2024-02-23 15:47:58 UTC
Maybe only large and small in enough.

Looks like small popups use around 4/3 ratio.
So small could be width=800,height=600

Large use a more 16/9 ratio.
So large could be width=1024,height=576

Actual width=800 and width=700 goes to small.
Actual width=900 may fit in small, must be validated.
Actual width=1000 goes to large.