Summary: | Add home library (homebranch) column to holds queue report | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Hold requests | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Needs documenting --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | blawlor, emily.lamancusa, fridolin.somers, gmcharlt, mspinney |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.05.00
|
Circulation function: | |
Attachments: |
Bug 35564: Add homebranch to the holds queue report
Bug 35564: Add homebranch to the holds queue report Bug 35564: Add homebranch to the holds queue report Bug 35564: Add homebranch to the holds queue report |
Description
Lucas Gass (lukeg)
2023-12-13 20:56:57 UTC
Created attachment 159815 [details] [review] Bug 35564: Add homebranch to the holds queue report To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no holding branch column 5 - APPLY PATCH 6 - Reload and try again 7 - Note the column is not there 8 - Click column setting gear to expose the column 9 - Go to Admin -> Table settings and make sure you can expose the column via Table settings Hi Lucas, I tested this and it mostly worked except for a couple things. #7 - the Home library column showed by default as soon as I refreshed the page #9 - I looked in http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#view_holdsqueue but did not see homelibrary as an option to configure there. Thanks for working on this! Created attachment 159816 [details] [review] Bug 35564: Add homebranch to the holds queue report To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no holding branch column 5 - APPLY PATCH 6 - Reload and try again 7 - Note the column is not there 8 - Click column setting gear to expose the column 9 - Go to Admin -> Table settings and make sure you can expose the column via Table settings Signed-off-by: Michelle <mspinney@clamsnet.org> (In reply to Brendan Lawlor from comment #2) > Hi Lucas, > > I tested this and it mostly worked except for a couple things. > > #7 - the Home library column showed by default as soon as I refreshed the > page > > #9 - I looked in > http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#view_holdsqueue > > but did not see homelibrary as an option to configure there. > > Thanks for working on this! Brendan, thanks for testing. I should have mentioned this in the test plan but failed to. You should restart services ( k-t-d: restart_all ) after applying the patch. Created attachment 159845 [details] [review] Bug 35564: Add homebranch to the holds queue report To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no holding branch column 5 - APPLY PATCH 6 - Reload and try again 7 - Note the column is not there 8 - Click column setting gear to expose the column 9 - Go to Admin -> Table settings and make sure you can expose the column via Table settings Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> restart_all was the step I was missing. Just tested this again and it worked. Thanks! (In reply to Lucas Gass from comment #4) > (In reply to Brendan Lawlor from comment #2) > > Hi Lucas, > > > > I tested this and it mostly worked except for a couple things. > > > > #7 - the Home library column showed by default as soon as I refreshed the > > page > > > > #9 - I looked in > > http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#view_holdsqueue > > > > but did not see homelibrary as an option to configure there. > > > > Thanks for working on this! > > Brendan, thanks for testing. I should have mentioned this in the test plan > but failed to. You should restart services ( k-t-d: restart_all ) after > applying the patch. Created attachment 161457 [details] [review] Bug 35564: Add homebranch to the holds queue report To test: 1 - Place some holds in your system 2 - perl misc/cronjobs/holds/build_holdsqueue.pl 3 - View the holds queue 4 - Note there is no holding branch column 5 - APPLY PATCH 6 - Reload and try again 7 - Note the column is not there 8 - Click column setting gear to expose the column 9 - Go to Admin -> Table settings and make sure you can expose the column via Table settings Signed-off-by: Michelle <mspinney@clamsnet.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Looks good, QA script is happy. Passing QA Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x |