Bug 35564 - Add homebranch column to holds queue report
Summary: Add homebranch column to holds queue report
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-13 20:56 UTC by Lucas Gass
Modified: 2024-01-25 19:46 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35564: Add homebranch to the holds queue report (3.44 KB, patch)
2023-12-13 21:00 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35564: Add homebranch to the holds queue report (3.49 KB, patch)
2023-12-13 21:54 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35564: Add homebranch to the holds queue report (3.49 KB, patch)
2023-12-14 14:38 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 35564: Add homebranch to the holds queue report (3.61 KB, patch)
2024-01-25 18:38 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-12-13 20:56:57 UTC
Some librarians need to be able to see the homebranch of items in the holds queue report.
Comment 1 Lucas Gass 2023-12-13 21:00:30 UTC
Created attachment 159815 [details] [review]
Bug 35564: Add homebranch to the holds queue report

To test:
1 - Place some holds in your system
2 - perl misc/cronjobs/holds/build_holdsqueue.pl
3 - View the holds queue
4 - Note there is no holding branch column
5 - APPLY PATCH
6 - Reload and try again
7 - Note the column is not there
8 - Click column setting gear to expose the column
9 - Go to Admin -> Table settings and make sure you can expose the column via Table settings
Comment 2 Brendan Lawlor 2023-12-13 21:41:46 UTC
Hi Lucas,

I tested this and it mostly worked except for a couple things.

#7 - the Home library column showed by default as soon as I refreshed the page
 
#9 - I looked in http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#view_holdsqueue

but did not see homelibrary as an option to configure there.

Thanks for working on this!
Comment 3 ByWater Sandboxes 2023-12-13 21:54:01 UTC
Created attachment 159816 [details] [review]
Bug 35564: Add homebranch to the holds queue report

To test:
1 - Place some holds in your system
2 - perl misc/cronjobs/holds/build_holdsqueue.pl
3 - View the holds queue
4 - Note there is no holding branch column
5 - APPLY PATCH
6 - Reload and try again
7 - Note the column is not there
8 - Click column setting gear to expose the column
9 - Go to Admin -> Table settings and make sure you can expose the column via Table settings

Signed-off-by: Michelle <mspinney@clamsnet.org>
Comment 4 Lucas Gass 2023-12-14 14:08:13 UTC
(In reply to Brendan Lawlor from comment #2)
> Hi Lucas,
> 
> I tested this and it mostly worked except for a couple things.
> 
> #7 - the Home library column showed by default as soon as I refreshed the
> page
>  
> #9 - I looked in
> http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#view_holdsqueue
> 
> but did not see homelibrary as an option to configure there.
> 
> Thanks for working on this!

Brendan, thanks for testing. I should have mentioned this in the test plan but failed to. You should restart services ( k-t-d: restart_all ) after applying the patch.
Comment 5 Brendan Lawlor 2023-12-14 14:38:33 UTC
Created attachment 159845 [details] [review]
Bug 35564: Add homebranch to the holds queue report

To test:
1 - Place some holds in your system
2 - perl misc/cronjobs/holds/build_holdsqueue.pl
3 - View the holds queue
4 - Note there is no holding branch column
5 - APPLY PATCH
6 - Reload and try again
7 - Note the column is not there
8 - Click column setting gear to expose the column
9 - Go to Admin -> Table settings and make sure you can expose the column via Table settings

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 6 Brendan Lawlor 2023-12-14 14:40:01 UTC
restart_all was the step I was missing. Just tested this again and it worked. Thanks!

(In reply to Lucas Gass from comment #4)
> (In reply to Brendan Lawlor from comment #2)
> > Hi Lucas,
> > 
> > I tested this and it mostly worked except for a couple things.
> > 
> > #7 - the Home library column showed by default as soon as I refreshed the
> > page
> >  
> > #9 - I looked in
> > http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#view_holdsqueue
> > 
> > but did not see homelibrary as an option to configure there.
> > 
> > Thanks for working on this!
> 
> Brendan, thanks for testing. I should have mentioned this in the test plan
> but failed to. You should restart services ( k-t-d: restart_all ) after
> applying the patch.
Comment 7 Emily Lamancusa 2024-01-25 18:38:16 UTC
Created attachment 161457 [details] [review]
Bug 35564: Add homebranch to the holds queue report

To test:
1 - Place some holds in your system
2 - perl misc/cronjobs/holds/build_holdsqueue.pl
3 - View the holds queue
4 - Note there is no holding branch column
5 - APPLY PATCH
6 - Reload and try again
7 - Note the column is not there
8 - Click column setting gear to expose the column
9 - Go to Admin -> Table settings and make sure you can expose the column via Table settings

Signed-off-by: Michelle <mspinney@clamsnet.org>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 8 Emily Lamancusa 2024-01-25 18:39:01 UTC
Looks good, QA script is happy. Passing QA