| Summary: | Missing closing div tag in bookings alert in circulation.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Staff interface | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.02
|
|
| Circulation function: | |||
| Bug Depends on: | 29002 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 35592: Fix closing tag in bookings alert
Bug 35592: Fix closing tag in bookings alert Bug 35592: Fix closing tag in bookings alert |
||
|
Description
Nick Clemens (kidclamp)
2023-12-18 16:15:08 UTC
Created attachment 159974 [details] [review] Bug 35592: Fix closing tag in bookings alert To test: 1 - View a record details page for a record with items 2 - Click on the 'Items' tab 3 - Change 'Bookable' to 'Yes' and update for an item 4 - View the details page - place a booking 5 - Checkout the item to the patron it is booked for 6 - Note the alert shows, but encompasses the whole page 7 - Apply patch 8 - Check in the item 9 - Checkout the item again 10 - Note the alert shows above the checkouts page as expected Created attachment 159983 [details] [review] Bug 35592: Fix closing tag in bookings alert To test: 1 - View a record details page for a record with items 2 - Click on the 'Items' tab 3 - Change 'Bookable' to 'Yes' and update for an item 4 - View the details page - place a booking 5 - Checkout the item to the patron it is booked for 6 - Note the alert shows, but encompasses the whole page 7 - Apply patch 8 - Check in the item 9 - Checkout the item again 10 - Note the alert shows above the checkouts page as expected Signed-off-by: David Nind <david@davidnind.com> I have signed off (from reviewing the patch), but I couldn't generate the issue described in the test plan. When I go to check out an item booked, I get this alert: Please confirm checkout Patron has this item booked for checkout on 12/19/2023 Allow early collection? Yes, check out (Y) No, don't check out (N) I don't get the alert, or know how to generate the area fixed in patch, which has the message "Item is booked by this user". Also, note bug 35532 - when using the "Place booking" button on the detail page, you need to double click the date to place a booking. Created attachment 159995 [details] [review] Bug 35592: Fix closing tag in bookings alert To test: 1 - View a record details page for a record with items 2 - Click on the 'Items' tab 3 - Change 'Bookable' to 'Yes' and update for an item 4 - View the details page - place a booking 5 - Checkout the item to the patron it is booked for 6 - Note the alert shows, but encompasses the whole page 7 - Apply patch 8 - Check in the item 9 - Checkout the item again 10 - Note the alert shows above the checkouts page as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks for the quick patch Nick.. Passing QA. I'll take a look at your comment shortly David. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Missing dependencies for 23.05.x, no backport. |