Bug 35592 - Missing closing div tag in bookings alert in circulation.tt
Summary: Missing closing div tag in bookings alert in circulation.tt
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 29002
Blocks:
  Show dependency treegraph
 
Reported: 2023-12-18 16:15 UTC by Nick Clemens
Modified: 2024-01-04 20:49 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02


Attachments
Bug 35592: Fix closing tag in bookings alert (1.39 KB, patch)
2023-12-18 16:25 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 35592: Fix closing tag in bookings alert (1.44 KB, patch)
2023-12-18 20:55 UTC, David Nind
Details | Diff | Splinter Review
Bug 35592: Fix closing tag in bookings alert (1.50 KB, patch)
2023-12-19 12:21 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-12-18 16:15:08 UTC

    
Comment 1 Nick Clemens 2023-12-18 16:25:04 UTC
Created attachment 159974 [details] [review]
Bug 35592: Fix closing tag in bookings alert

To test:
1 - View a record details page for a record with items
2 - Click on the 'Items' tab
3 - Change 'Bookable' to 'Yes' and update for an item
4 - View the details page - place a booking
5 - Checkout the item to the patron it is booked for
6 - Note the alert shows, but encompasses the whole page
7 - Apply patch
8 - Check in the item
9 - Checkout the item again
10 - Note the alert shows above the checkouts page as expected
Comment 2 David Nind 2023-12-18 20:55:09 UTC
Created attachment 159983 [details] [review]
Bug 35592: Fix closing tag in bookings alert

To test:
1 - View a record details page for a record with items
2 - Click on the 'Items' tab
3 - Change 'Bookable' to 'Yes' and update for an item
4 - View the details page - place a booking
5 - Checkout the item to the patron it is booked for
6 - Note the alert shows, but encompasses the whole page
7 - Apply patch
8 - Check in the item
9 - Checkout the item again
10 - Note the alert shows above the checkouts page as expected

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-12-18 21:01:58 UTC
I have signed off (from reviewing the patch), but I couldn't generate the issue described in the test plan.

When I go to check out an item booked, I get this alert:

   Please confirm checkout

   Patron has this item booked for checkout on 12/19/2023

   Allow early collection?
 
   Yes, check out (Y)
   No, don't check out (N)

I don't get the alert, or know how to generate the area fixed in patch, which has the message "Item is booked by this user".

Also, note bug 35532 - when using the "Place booking" button on the detail page, you need to double click the date to place a booking.
Comment 4 Martin Renvoize 2023-12-19 12:21:08 UTC
Created attachment 159995 [details] [review]
Bug 35592: Fix closing tag in bookings alert

To test:
1 - View a record details page for a record with items
2 - Click on the 'Items' tab
3 - Change 'Bookable' to 'Yes' and update for an item
4 - View the details page - place a booking
5 - Checkout the item to the patron it is booked for
6 - Note the alert shows, but encompasses the whole page
7 - Apply patch
8 - Check in the item
9 - Checkout the item again
10 - Note the alert shows above the checkouts page as expected

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-12-19 12:21:42 UTC
Thanks for the quick patch Nick.. Passing QA.

I'll take a look at your comment shortly David.
Comment 6 Katrin Fischer 2023-12-19 12:44:13 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-03 15:25:30 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass 2024-01-04 20:49:45 UTC
Missing dependencies for 23.05.x, no backport.