| Summary: | Upgrade Chocolat JS library from v1.1.0 to v1.1.2 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Architecture, internals, and plumbing | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, fridolin.somers, testopia, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 35584, 28180 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 35633: Upgrade Chocolat JS library from v1.1.0 to v1.1.2
Bug 35633: (follow-up) Custom style updates Bug 35633: Upgrade Chocolat JS library from v1.1.0 to v1.1.2 Bug 35633: (follow-up) Custom style updates Bug 35633: (follow-up) Custom style updates Bug 35633: Upgrade Chocolat JS library from v1.1.0 to v1.1.2 Bug 35633: (follow-up) Custom style updates |
||
|
Description
Owen Leonard
2023-12-21 19:15:50 UTC
Created attachment 160217 [details] [review] Bug 35633: Upgrade Chocolat JS library from v1.1.0 to v1.1.2 This patch updates Chocolat JS library assets from v1.1.0 to v1.1.2 in both the OPAC and staff interface. The new version uses SVG images encoded as data-uris in CSS, so default images can now be overridden in our CSS. For that reason the Chocolat-related images files are removed by this patch. Created attachment 160218 [details] [review] Bug 35633: (follow-up) Custom style updates This patch adds custom CSS to the OPAC and staff interface to override the default style of Chocolat controls (for left arrow, right arrow, loading, and close window). These controls are given a green color matching Koha's color scheme. The bibliographic detail pages in the OPAC and staff interface have been revised so that the inclusion of Chocolat CSS comes before the inclusion of Koha's global CSS. We should do this with third-party CSS so that it can be more easily overridden by ours. The patch also makes a minor change to chocolat.js to correct a bug. See commit 6ac89ca8558. To test, apply the patch and rebuild the OPAC and staff interface CSS. - Go to Administration -> System preferences and enable the AllowMultipleCovers, OPACLocalCoverImages, and LocalCoverImages system preferences. - Add a local cover image to a bibliographic record: - Locate a bibliographic record. - From the detail page, click the "Images" tab and then "Upload." - Upload an image to attach to the record. - Upload another image. - Return to the bibliographic detail page fro that record, and click the image you uploaded. - The full-page image viewer should appear, and the controls should look correct, with green matching Koha's color scheme: - The close button in the upper-right - The right-arrow, and then when you click through to the second image, the left-arrow. - In the footer, the "edit" link should work correctly. - Test that the "Full screen" control works too. - Click the "OPAC view" link to load the record in the OPAC, and perform the same tests. Created attachment 160219 [details] [review] Bug 35633: Upgrade Chocolat JS library from v1.1.0 to v1.1.2 This patch updates Chocolat JS library assets from v1.1.0 to v1.1.2 in both the OPAC and staff interface. The new version uses SVG images encoded as data-uris in CSS, so default images can now be overridden in our CSS. For that reason the Chocolat-related images files are removed by this patch. Created attachment 160220 [details] [review] Bug 35633: (follow-up) Custom style updates This patch adds custom CSS to the OPAC and staff interface to override the default style of Chocolat controls (for left arrow, right arrow, loading, and close window). These controls are given a green color matching Koha's color scheme. The bibliographic detail pages in the OPAC and staff interface have been revised so that the inclusion of Chocolat CSS comes before the inclusion of Koha's global CSS. We should do this with third-party CSS so that it can be more easily overridden by ours. The patch also makes a minor change to chocolat.js to correct a bug. See commit 6ac89ca8558. To test, apply the patch and rebuild the OPAC and staff interface CSS. - Go to Administration -> System preferences and enable the AllowMultipleCovers, OPACLocalCoverImages, and LocalCoverImages system preferences. - Add a local cover image to a bibliographic record: - Locate a bibliographic record. - From the detail page, click the "Images" tab and then "Upload." - Upload an image to attach to the record. - Upload another image. - Return to the bibliographic detail page fro that record, and click the image you uploaded. - The full-page image viewer should appear, and the controls should look correct, with green matching Koha's color scheme: - The close button in the upper-right - The right-arrow, and then when you click through to the second image, the left-arrow. - In the footer, the "edit" link should work correctly. - Test that the "Full screen" control works too. - Click the "OPAC view" link to load the record in the OPAC, and perform the same tests. Created attachment 160667 [details] [review] Bug 35633: (follow-up) Custom style updates This patch adds custom CSS to the OPAC and staff interface to override the default style of Chocolat controls (for left arrow, right arrow, loading, and close window). These controls are given a green color matching Koha's color scheme. The bibliographic detail pages in the OPAC and staff interface have been revised so that the inclusion of Chocolat CSS comes before the inclusion of Koha's global CSS. We should do this with third-party CSS so that it can be more easily overridden by ours. The patch also makes a minor change to chocolat.js to correct a bug. See commit 6ac89ca8558. To test, apply the patch and rebuild the OPAC and staff interface CSS. - Go to Administration -> System preferences and enable the AllowMultipleCovers, OPACLocalCoverImages, and LocalCoverImages system preferences. - Add a local cover image to a bibliographic record: - Locate a bibliographic record. - From the detail page, click the "Images" tab and then "Upload." - Upload an image to attach to the record. - Upload another image. - Return to the bibliographic detail page fro that record, and click the image you uploaded. - The full-page image viewer should appear, and the controls should look correct, with green matching Koha's color scheme: - The close button in the upper-right - The right-arrow, and then when you click through to the second image, the left-arrow. - In the footer, the "edit" link should work correctly. - Test that the "Full screen" control works too. - Click the "OPAC view" link to load the record in the OPAC, and perform the same tests. - Nicely done! Signed-off-by: Phan Tung Bui <phan-tung.bui@inlibro.com> Created attachment 160926 [details] [review] Bug 35633: Upgrade Chocolat JS library from v1.1.0 to v1.1.2 This patch updates Chocolat JS library assets from v1.1.0 to v1.1.2 in both the OPAC and staff interface. The new version uses SVG images encoded as data-uris in CSS, so default images can now be overridden in our CSS. For that reason the Chocolat-related images files are removed by this patch. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 160927 [details] [review] Bug 35633: (follow-up) Custom style updates This patch adds custom CSS to the OPAC and staff interface to override the default style of Chocolat controls (for left arrow, right arrow, loading, and close window). These controls are given a green color matching Koha's color scheme. The bibliographic detail pages in the OPAC and staff interface have been revised so that the inclusion of Chocolat CSS comes before the inclusion of Koha's global CSS. We should do this with third-party CSS so that it can be more easily overridden by ours. The patch also makes a minor change to chocolat.js to correct a bug. See commit 6ac89ca8558. To test, apply the patch and rebuild the OPAC and staff interface CSS. - Go to Administration -> System preferences and enable the AllowMultipleCovers, OPACLocalCoverImages, and LocalCoverImages system preferences. - Add a local cover image to a bibliographic record: - Locate a bibliographic record. - From the detail page, click the "Images" tab and then "Upload." - Upload an image to attach to the record. - Upload another image. - Return to the bibliographic detail page fro that record, and click the image you uploaded. - The full-page image viewer should appear, and the controls should look correct, with green matching Koha's color scheme: - The close button in the upper-right - The right-arrow, and then when you click through to the second image, the left-arrow. - In the footer, the "edit" link should work correctly. - Test that the "Full screen" control works too. - Click the "OPAC view" link to load the record in the OPAC, and perform the same tests. Signed-off-by: Phan Tung Bui <phan-tung.bui@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x Yum, Chocolat! Module(?) change, nothing to add/edit in the Koha manual. |