Summary: | 'Check the logs' string dot-inconsistent | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This makes 'Check the logs..' messages more consistent across Koha, including the use of full stops. It also fixes up other related inconsistencies. These changes should make translations easier as well.
|
|
Version(s) released in: |
24.05.00,23.11.02
|
Circulation function: | |
Attachments: |
Bug 35650: Standardize on 'Check the logs for details.'
Bug 35650: (follow-up) Other cases found Bug 35650: Standardize on 'Check the logs for details.' Bug 35650: (follow-up) Other cases found Bug 35650: Standardize on 'Check the logs for details.' Bug 35650: (follow-up) Other cases found |
Description
Tomás Cohen Arazi (tcohen)
2023-12-26 13:36:25 UTC
Created attachment 160295 [details] [review] Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 160296 [details] [review] Bug 35650: (follow-up) Other cases found while editing files for the main patch, I noticed some tiny cases. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 160303 [details] [review] Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 160304 [details] [review] Bug 35650: (follow-up) Other cases found while editing files for the main patch, I noticed some tiny cases. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> A nice tidy up! Thanks Tomás. Created attachment 160587 [details] [review] Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 160588 [details] [review] Bug 35650: (follow-up) Other cases found while editing files for the main patch, I noticed some tiny cases. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Doesn't apply cleanly to 23.05.x, no backport. |