I found this when translating. If you run: $ git grep 'Check the logs' you will notice in most cases the structure is: <Something happened>. Check the logs. or <Something happened>. Check the logs for details But in some the dot is missing. The inconsistency causes (probably) the constant changes in the translation system in which the same string sometimes has the dot, sometimes it doesn't and it is changed all the time the same way. I think the correct form is to use the dot, and is also the more widespread. So I'm proposing to stick with using the dot: $ git grep 'Check the logs' | wc -l 31 $ git grep 'Check the logs\.' | wc -l 17 $ git grep 'Check the logs ' | wc -l 3 $ git grep -e 'Check the logs\"' -e 'Check the logs<' | wc -l 11
Created attachment 160295 [details] [review] Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 160296 [details] [review] Bug 35650: (follow-up) Other cases found while editing files for the main patch, I noticed some tiny cases. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 160303 [details] [review] Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 160304 [details] [review] Bug 35650: (follow-up) Other cases found while editing files for the main patch, I noticed some tiny cases. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
A nice tidy up! Thanks Tomás.
Created attachment 160587 [details] [review] Bug 35650: Standardize on 'Check the logs for details.' This patch makes the 'Check the logs..' messages more consistent across the codebase. To test: 1. Run: $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.' => FAIL: Several forms show up 2. Apply this patch 3. Repeat 1 => SUCCESS: Empty result. 4. Run: $ git grep -e 'Check the logs for details\.' => SUCCESS: Consisten results show 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 160588 [details] [review] Bug 35650: (follow-up) Other cases found while editing files for the main patch, I noticed some tiny cases. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Doesn't apply cleanly to 23.05.x, no backport.