Bug 35663

Summary: Wording on OPAC privacy page is misleading
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, george
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.09
Circulation function:
Attachments: Bug 35663: Reword default privacy option in opac-privacy.pl
Bug 35663: Reword default privacy option in opac-privacy.pl
Bug 35663: Reword default privacy option in opac-privacy.pl

Description Lucas Gass (lukeg) 2023-12-28 19:59:00 UTC
Default: keep my history according to local laws. This is the default option : the library will keep your history for the duration permitted by local laws.

This is based on the days flag in the batch_anonymise.pl cron, not local laws. That is misleading and should be updated.
Comment 1 Katrin Fischer 2023-12-28 20:26:08 UTC
Hm, I think the text was probably chosen to keep it general. I am not sure if we can grab the value from the cron unless we move it into a system preference.
Comment 2 Lucas Gass (lukeg) 2023-12-28 20:41:55 UTC
(In reply to Katrin Fischer from comment #1)
> Hm, I think the text was probably chosen to keep it general. I am not sure
> if we can grab the value from the cron unless we move it into a system
> preference.

At the very least we need to avoid using "local laws" because it is misleading. In fact, it is completely false!
Comment 3 George Williams (NEKLS) 2023-12-29 15:30:07 UTC
I'd be happier if the text "duration permitted by local laws." was replaced with "duration set by library policy."
Comment 4 Katrin Fischer 2023-12-30 14:25:24 UTC
(In reply to George Williams (NEKLS) from comment #3)
> I'd be happier if the text "duration permitted by local laws." was replaced
> with "duration set by library policy."

I think this is a good suggestion.
Comment 5 Owen Leonard 2024-01-02 13:59:14 UTC
Created attachment 160405 [details] [review]
Bug 35663: Reword default privacy option in opac-privacy.pl

This patch updates the description of the OPAC privacy page, replacing:

"Default: keep my history according to local laws. This is the default
option : the library will keep your history for the duration permitted
by local laws."

...with:

"Default: keep my history according to library policy. This is the
default option : the library will keep your history for the duration set
by library policy."

This correctly reflects the fact that privacy is managed according to a
Koha cron configuration.

To test, apply the patch and make sure the OPACPrivacy and related
preferences are enabled.

- Log in to the OPAC and click the "Privacy" tab in the left-hand
  sidebar.
- Confirm that the description of the default privacy option is correct.
Comment 6 Lucas Gass (lukeg) 2024-01-02 14:46:49 UTC
Created attachment 160408 [details] [review]
Bug 35663: Reword default privacy option in opac-privacy.pl

This patch updates the description of the OPAC privacy page, replacing:

"Default: keep my history according to local laws. This is the default
option : the library will keep your history for the duration permitted
by local laws."

...with:

"Default: keep my history according to library policy. This is the
default option : the library will keep your history for the duration set
by library policy."

This correctly reflects the fact that privacy is managed according to a
Koha cron configuration.

To test, apply the patch and make sure the OPACPrivacy and related
preferences are enabled.

- Log in to the OPAC and click the "Privacy" tab in the left-hand
  sidebar.
- Confirm that the description of the default privacy option is correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Lucas Gass (lukeg) 2024-01-02 14:49:37 UTC
Thanks Owen!
Comment 8 Jonathan Druart 2024-01-12 10:47:38 UTC
Created attachment 160923 [details] [review]
Bug 35663: Reword default privacy option in opac-privacy.pl

This patch updates the description of the OPAC privacy page, replacing:

"Default: keep my history according to local laws. This is the default
option : the library will keep your history for the duration permitted
by local laws."

...with:

"Default: keep my history according to library policy. This is the
default option : the library will keep your history for the duration set
by library policy."

This correctly reflects the fact that privacy is managed according to a
Koha cron configuration.

To test, apply the patch and make sure the OPACPrivacy and related
preferences are enabled.

- Log in to the OPAC and click the "Privacy" tab in the left-hand
  sidebar.
- Confirm that the description of the default privacy option is correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Katrin Fischer 2024-01-16 15:36:12 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 10 Fridolin Somers 2024-01-31 12:24:32 UTC
Pushed to 23.11.x for 23.11.03
Comment 11 Lucas Gass (lukeg) 2024-02-08 18:45:56 UTC
Backported to 23.05.x for upcoming 23.05.09