Default: keep my history according to local laws. This is the default option : the library will keep your history for the duration permitted by local laws. This is based on the days flag in the batch_anonymise.pl cron, not local laws. That is misleading and should be updated.
Hm, I think the text was probably chosen to keep it general. I am not sure if we can grab the value from the cron unless we move it into a system preference.
(In reply to Katrin Fischer from comment #1) > Hm, I think the text was probably chosen to keep it general. I am not sure > if we can grab the value from the cron unless we move it into a system > preference. At the very least we need to avoid using "local laws" because it is misleading. In fact, it is completely false!
I'd be happier if the text "duration permitted by local laws." was replaced with "duration set by library policy."
(In reply to George Williams (NEKLS) from comment #3) > I'd be happier if the text "duration permitted by local laws." was replaced > with "duration set by library policy." I think this is a good suggestion.
Created attachment 160405 [details] [review] Bug 35663: Reword default privacy option in opac-privacy.pl This patch updates the description of the OPAC privacy page, replacing: "Default: keep my history according to local laws. This is the default option : the library will keep your history for the duration permitted by local laws." ...with: "Default: keep my history according to library policy. This is the default option : the library will keep your history for the duration set by library policy." This correctly reflects the fact that privacy is managed according to a Koha cron configuration. To test, apply the patch and make sure the OPACPrivacy and related preferences are enabled. - Log in to the OPAC and click the "Privacy" tab in the left-hand sidebar. - Confirm that the description of the default privacy option is correct.
Created attachment 160408 [details] [review] Bug 35663: Reword default privacy option in opac-privacy.pl This patch updates the description of the OPAC privacy page, replacing: "Default: keep my history according to local laws. This is the default option : the library will keep your history for the duration permitted by local laws." ...with: "Default: keep my history according to library policy. This is the default option : the library will keep your history for the duration set by library policy." This correctly reflects the fact that privacy is managed according to a Koha cron configuration. To test, apply the patch and make sure the OPACPrivacy and related preferences are enabled. - Log in to the OPAC and click the "Privacy" tab in the left-hand sidebar. - Confirm that the description of the default privacy option is correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Thanks Owen!
Created attachment 160923 [details] [review] Bug 35663: Reword default privacy option in opac-privacy.pl This patch updates the description of the OPAC privacy page, replacing: "Default: keep my history according to local laws. This is the default option : the library will keep your history for the duration permitted by local laws." ...with: "Default: keep my history according to library policy. This is the default option : the library will keep your history for the duration set by library policy." This correctly reflects the fact that privacy is managed according to a Koha cron configuration. To test, apply the patch and make sure the OPACPrivacy and related preferences are enabled. - Log in to the OPAC and click the "Privacy" tab in the left-hand sidebar. - Confirm that the description of the default privacy option is correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03
Backported to 23.05.x for upcoming 23.05.09