Description
Laura Escamilla
2023-12-29 17:03:30 UTC
Created attachment 160371 [details] [review] Bug 35669: Update check in messages to match the lost authorised value. To test: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." 3. Apply the patch. 4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.” 5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions. 6. Sign off and have a wonderful day :) Created attachment 160383 [details] [review] Bug 35669: Update check in messages to match the lost authorised value. To test: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." 3. Apply the patch. 4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.” 5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions. 6. Sign off and have a wonderful day :) Signed-off-by: David Nind <david@davidnind.com> FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL filters missing_filter at line 342 ( <p class="problem ret_checkedin">Item was [% itemlost_description %], now found.</p>) Created attachment 165526 [details] [review] Bug 35669: Update check in messages to match the lost authorised value. I'me getting the sha1/fake ancestor error message when trying to apply the patch. git bz apply 35669 Bug 35669 - Update check in message for a specific authorised value in the LOST authorised values 165526 - Bug 35669: Update check in messages to match the lost authorised value. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35669: Update check in messages to match the lost authorised value. error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor Patch failed at 0001 Bug 35669: Update check in messages to match the lost authorised value. Created attachment 165651 [details] [review] Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values (edit) To test: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." 3. Apply the patch. 4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.” 5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions. 6. Sign off and have a wonderful day :) Created attachment 169501 [details] [review] Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values To test: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." 3. Apply the patch. 4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.” 5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions. 6. Sign off and have a wonderful day :) Created attachment 169520 [details] [review] Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> The missing filter issue is still here. Maybe the attachment on comment 4 was the wrong patch? ----- The test plan should be in the commit message. So that it's not lost in reuploads like it happened here. And so it's in the git log to help when searching old commits or test plan parts when trying to do something. --- commit summary needs minor formatting fix: "Bug 35669 - " => "Bug 35669: " Created attachment 183472 [details] [review] Bug 35669: Update check-in message to show specific LOST authorised value descriptions To test: 1. Set an item’s Lost status to "Lost". When you check in that item, you should see the message: “Item was lost, now found.” 2. Set an item’s Lost status to "Missing". When you check in that item, you should see the message: “Item was lost, now found.” (default behavior before patch) 3. Apply the patch. 4. Set an item’s Lost status to "Missing" again. When you check in that item, the message should now be: “Item was Missing, now found.” (using the authorised value description) 5. Repeat step 4 with other custom LOST authorised values. The check-in message should correctly reflect the corresponding authorised value descriptions. 6. Sign off and have a wonderful day! 😊 Created attachment 183476 [details] [review] Bug 35669: Update check-in message to show specific LOST authorised value descriptions This displays the LOST authorized value description when checking an item in, instead of the generic "Item was lost, now found." message. Test plan: 1. Set an item’s Lost status to "Lost". When you check in that item, you should see the message: “Item was lost, now found.” 2. Set an item’s Lost status to "Missing". When you check in that item, you should see the message: “Item was lost, now found.” (default behavior before patch) 3. Apply the patch. 4. Set an item’s Lost status to "Missing" again. When you check in that item, the message should now be: “Item was Missing, now found.” (using the authorised value description) 5. Repeat step 4 with other custom LOST authorised values. The check-in message should correctly reflect the corresponding authorised value descriptions. 6. Sign off and have a wonderful day! 😊 Signed-off-by: David Nind <david@davidnind.com> I amended the commit message - see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages |