Bug 35669 - Update check in message for a specific authorised value in the LOST authorised values
Summary: Update check in message for a specific authorised value in the LOST authorise...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Laura Escamilla
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-29 17:03 UTC by Laura Escamilla
Modified: 2024-07-24 21:13 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement displays the LOST authorized value description when checking an item in, instead of the generic "Item was lost, now found." message. For example, if the LOST value description is "Missing" it will now display as "Item was Missing, now found.".
Version(s) released in:
Circulation function:

Attachments
Bug 35669: Update check in messages to match the lost authorised value. (2.39 KB, patch)
2023-12-29 17:11 UTC, Laura Escamilla 		Details | Diff | Splinter Review
Bug 35669: Update check in messages to match the lost authorised value. (2.44 KB, patch)
2023-12-31 20:29 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35669: Update check in messages to match the lost authorised value. (1.61 KB, patch)
2024-04-25 11:50 UTC, Laura Escamilla 		Details | Diff | Splinter Review
Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values (edit) To test: (2.43 KB, patch)
2024-04-26 12:08 UTC, Laura Escamilla 		Details | Diff | Splinter Review
Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values (1.73 KB, patch)
2024-07-24 15:52 UTC, Laura Escamilla 		Details | Diff | Splinter Review
Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values (1.79 KB, patch)
2024-07-24 21:13 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2023-12-29 17:03:30 UTC 
To recreate:

1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found."
2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found."

Some libraries would like this message to reflect the correct authorised value that was previously set. So if they have a lost value of "In repair", the check in message would say "Item was In repair, now found."
Comment 1 Laura Escamilla 2023-12-29 17:11:07 UTC 
Created attachment 160371 [details] [review]
Bug 35669: Update check in messages to match the lost authorised value.

To test:

1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found."
2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found."
3. Apply the patch.
4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.”
5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions.
6. Sign off and have a wonderful day :)
Comment 2 David Nind 2023-12-31 20:29:46 UTC 
Created attachment 160383 [details] [review]
Bug 35669: Update check in messages to match the lost authorised value.

To test:

1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found."
2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found."
3. Apply the patch.
4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.”
5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions.
6. Sign off and have a wonderful day :)

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-04-18 12:14:17 UTC 
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
   FAIL   filters
                missing_filter at line 342 (                                                <p class="problem ret_checkedin">Item was [% itemlost_description %], now found.</p>)
Comment 4 Laura Escamilla 2024-04-25 11:50:26 UTC 
Created attachment 165526 [details] [review]
Bug 35669: Update check in messages to match the lost authorised value.
Comment 5 David Nind 2024-04-26 08:48:44 UTC 
I'me getting the sha1/fake ancestor error message when trying to apply the patch.

git bz apply 35669

Bug 35669 - Update check in message for a specific authorised value in the LOST authorised values

165526 - Bug 35669: Update check in messages to match the lost authorised value.

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 35669: Update check in messages to match the lost authorised value.
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 35669: Update check in messages to match the lost authorised value.
Comment 6 Laura Escamilla 2024-04-26 12:08:02 UTC Comment hidden (obsolete)
Comment 7 Laura Escamilla 2024-07-24 15:52:21 UTC 
Created attachment 169501 [details] [review]
Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values

To test:

1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found."
2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found."
3. Apply the patch.
4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.”
5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions.
6. Sign off and have a wonderful day :)
Comment 8 ByWater Sandboxes 2024-07-24 21:13:12 UTC 
Created attachment 169520 [details] [review]
Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>