Summary: | OPAC search results - link for "Check for suggestions" generates a blank page | ||
---|---|---|---|
Product: | Koha | Reporter: | David Nind <david> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bibliothek, fridolin.somers, jonathan.druart, kyle, lucas, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.05.00,23.11.02
|
Circulation function: | |
Bug Depends on: | 34866 | ||
Bug Blocks: | |||
Attachments: |
Bug 35676: Fix DidYouMean when not configured
Bug 35676: Fix DidYouMean when not configured Bug 35676: Fix DidYouMean when not configured |
Description
David Nind
2023-12-31 18:56:14 UTC
Created attachment 160942 [details] [review] Bug 35676: Fix DidYouMean when not configured When DidYouMean is not configured, there is the following message displayed: "Not what you expected? Check for suggestions" suggestions is a link to svc/suggestion which does not return content if the feature is displayed 90 unless ( @plugins ) { 91 print $query->header; 92 exit; 93 } We should not see this text, it is supposed to be replaced when the ft is enabled. However commit 79bf4485c1b2ae8059e2ee15ea1e67bba9961c34 Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 made this change: - [% IF ( DidYouMean ) %] + [% #IF ( DidYouMean ) %] <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> - [% END %] + [% #END %] Which is obviously wrong. Test plan: Do not have the ft configured and launch a search (OPAC) that will not return any results. => Without this patch there is the message => With this patch applied it is no longer displayed Created attachment 160962 [details] [review] Bug 35676: Fix DidYouMean when not configured When DidYouMean is not configured, there is the following message displayed: "Not what you expected? Check for suggestions" suggestions is a link to svc/suggestion which does not return content if the feature is displayed 90 unless ( @plugins ) { 91 print $query->header; 92 exit; 93 } We should not see this text, it is supposed to be replaced when the ft is enabled. However commit 79bf4485c1b2ae8059e2ee15ea1e67bba9961c34 Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 made this change: - [% IF ( DidYouMean ) %] + [% #IF ( DidYouMean ) %] <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> - [% END %] + [% #END %] Which is obviously wrong. Test plan: Do not have the ft configured and launch a search (OPAC) that will not return any results. => Without this patch there is the message => With this patch applied it is no longer displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 160970 [details] [review] Bug 35676: Fix DidYouMean when not configured When DidYouMean is not configured, there is the following message displayed: "Not what you expected? Check for suggestions" suggestions is a link to svc/suggestion which does not return content if the feature is displayed 90 unless ( @plugins ) { 91 print $query->header; 92 exit; 93 } We should not see this text, it is supposed to be replaced when the ft is enabled. However commit 79bf4485c1b2ae8059e2ee15ea1e67bba9961c34 Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 made this change: - [% IF ( DidYouMean ) %] + [% #IF ( DidYouMean ) %] <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> - [% END %] + [% #END %] Which is obviously wrong. Test plan: Do not have the ft configured and launch a search (OPAC) that will not return any results. => Without this patch there is the message => With this patch applied it is no longer displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 *** Bug 35958 has been marked as a duplicate of this bug. *** Based on Bug 35958 it looks like folks on 23.05 would like a backport. (In reply to Owen Leonard from comment #8) > Based on Bug 35958 it looks like folks on 23.05 would like a backport. Sorry for wrong version tag in bug 35958 as we ware already running 23.11.01. |