Bug 34866 - Use template wrapper for breadcrumbs: OPAC part 4
Summary: Use template wrapper for breadcrumbs: OPAC part 4
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords: Sandbox
Depends on: 34849
Blocks: 35676
  Show dependency tree / graph
 
Reported: 2023-09-21 15:02 UTC by Owen Leonard
Modified: 2024-01-12 12:46 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 (25.17 KB, patch)
2023-09-21 16:41 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 (25.65 KB, patch)
2023-11-02 10:47 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 (25.69 KB, patch)
2023-11-02 14:49 UTC, David Nind 		Details | Diff | Splinter Review
Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4 (25.75 KB, patch)
2023-11-04 13:20 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-09-21 15:02:51 UTC 
To continue the process started by Bug 32507, this patch will update several templates in the OPAC so that they use the template wrapper for breadcrumbs.

- opac-registration-confirmation.tt
- opac-registration-email-sent.tt
- opac-registration-invalid.tt
- opac-request-article.tt
- opac-reserve.tt
- opac-results.tt
- opac-serial-issues.tt
- opac-shareshelf.tt
- opac-showreviews.tt
- opac-suggestions.tt
- opac-tags_subject.tt
- opac-topissues.tt
- svc/suggestion.tt
Comment 1 Owen Leonard 2023-09-21 16:41:33 UTC 
Created attachment 156004 [details] [review]
Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- Recent comments
- Most popular
- Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail"
  to "Don't require."
  - In the OPAC, go to "Register here." Fill out the form and submit
    your registration.
  - Check the "Registration complete" page.
- Set "PatronSelfRegistrationVerifyByEmail" to "Require"
  - Submit another registration and check the "Confirm your
    registration" page.
- Visit the registration page passing an invalid token:
  /cgi-bin/koha/opac-registration-verify.pl?token=foo
  Check the "Registration invalid" page.
- Enable the "ArticleRequests" system preference and log in to the
  OPAC.
  - Perform a search which will return results.
    - Check the search results page
    - View the detail page for one of the results.
     - Click "Request article."
    - Return to the detail page and click "Place hold."
      - Complete each step of the hold process.
- Enable the "OpacAllowSharingPrivateLists" system preference.
  - Create a private list if necessary.
  - Click the "Share" link
- Locate a serial record and view the detail page.
  - Click the "More details" link under the "Subscriptions" plan
- Enable the system preference "suggestion."
  - From the logged-in user summary page click "Purchase suggestions"
    - Click the "New purchase suggestion" link
- Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system
  preferences and log out of the OPAC.
  - View the purchase suggestions page.
- Enable the "OpacCloud" system preference and go to the "Subject cloud"
  page. (the feature doesn't need to be configured to test).
- Populate the "RestrictedPageTitle" and "RestrictedPageContent" system
  preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl
  - Remove the contents of "RestrictedPageTitle" and check the page
    again.
- This patch also updates svc/suggestion.tt but I don't know how to test
  it!
Comment 2 David Nind 2023-11-02 06:51:46 UTC 
Patch no longer applies 8-(..

kohadev-koha@kohadevbox:koha(bz34866)$ git bz apply 34866

Bug 34866 - Use template wrapper for breadcrumbs: OPAC part 4

156004 - Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4
Using index info to reconstruct a base tree...
M	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
M	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
M	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
M	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4
Comment 3 Owen Leonard 2023-11-02 10:47:49 UTC 
Created attachment 158239 [details] [review]
Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- Recent comments
- Most popular
- Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail"
  to "Don't require."
  - In the OPAC, go to "Register here." Fill out the form and submit
    your registration.
  - Check the "Registration complete" page.
- Set "PatronSelfRegistrationVerifyByEmail" to "Require"
  - Submit another registration and check the "Confirm your
    registration" page.
- Visit the registration page passing an invalid token:
  /cgi-bin/koha/opac-registration-verify.pl?token=foo
  Check the "Registration invalid" page.
- Enable the "ArticleRequests" system preference and log in to the
  OPAC.
  - Perform a search which will return results.
    - Check the search results page
    - View the detail page for one of the results.
     - Click "Request article."
    - Return to the detail page and click "Place hold."
      - Complete each step of the hold process.
- Enable the "OpacAllowSharingPrivateLists" system preference.
  - Create a private list if necessary.
  - Click the "Share" link
- Locate a serial record and view the detail page.
  - Click the "More details" link under the "Subscriptions" plan
- Enable the system preference "suggestion."
  - From the logged-in user summary page click "Purchase suggestions"
    - Click the "New purchase suggestion" link
- Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system
  preferences and log out of the OPAC.
  - View the purchase suggestions page.
- Enable the "OpacCloud" system preference and go to the "Subject cloud"
  page. (the feature doesn't need to be configured to test).
- Populate the "RestrictedPageTitle" and "RestrictedPageContent" system
  preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl
  - Remove the contents of "RestrictedPageTitle" and check the page
    again.
- This patch also updates svc/suggestion.tt but I don't know how to test
  it!
Comment 4 David Nind 2023-11-02 14:49:25 UTC 
Created attachment 158265 [details] [review]
Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- Recent comments
- Most popular
- Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail"
  to "Don't require."
  - In the OPAC, go to "Register here." Fill out the form and submit
    your registration.
  - Check the "Registration complete" page.
- Set "PatronSelfRegistrationVerifyByEmail" to "Require"
  - Submit another registration and check the "Confirm your
    registration" page.
- Visit the registration page passing an invalid token:
  /cgi-bin/koha/opac-registration-verify.pl?token=foo
  Check the "Registration invalid" page.
- Enable the "ArticleRequests" system preference and log in to the
  OPAC.
  - Perform a search which will return results.
    - Check the search results page
    - View the detail page for one of the results.
     - Click "Request article."
    - Return to the detail page and click "Place hold."
      - Complete each step of the hold process.
- Enable the "OpacAllowSharingPrivateLists" system preference.
  - Create a private list if necessary.
  - Click the "Share" link
- Locate a serial record and view the detail page.
  - Click the "More details" link under the "Subscriptions" plan
- Enable the system preference "suggestion."
  - From the logged-in user summary page click "Purchase suggestions"
    - Click the "New purchase suggestion" link
- Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system
  preferences and log out of the OPAC.
  - View the purchase suggestions page.
- Enable the "OpacCloud" system preference and go to the "Subject cloud"
  page. (the feature doesn't need to be configured to test).
- Populate the "RestrictedPageTitle" and "RestrictedPageContent" system
  preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl
  - Remove the contents of "RestrictedPageTitle" and check the page
    again.
- This patch also updates svc/suggestion.tt but I don't know how to test
  it!

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-11-02 14:54:46 UTC 
Testing notes (using KTD):

1. Enable OpacShowRecentComments and OpacTopissue system preferences

2. Set AnonymousPatron for anonymous suggestions form to appear (otherwise, you are prompted to log in).
Comment 6 Katrin Fischer 2023-11-04 13:15:20 UTC 
Will these ever end? :)
Comment 7 Katrin Fischer 2023-11-04 13:20:58 UTC 
Created attachment 158384 [details] [review]
Bug 34866: Use template wrapper for breadcrumbs: OPAC part 4

This patch updates several OPAC templates so that they
use a new WRAPPER for displaying breadcrumbs.

Apply the patch and log in to the OPAC. Test each of the following pages
and their variations. Breadcrumbs should look correct, and each link
should be correct:

- Recent comments
- Most popular
- Enable "PatronSelfRegistration" and set "PatronSelfRegistrationVerifyByEmail"
  to "Don't require."
  - In the OPAC, go to "Register here." Fill out the form and submit
    your registration.
  - Check the "Registration complete" page.
- Set "PatronSelfRegistrationVerifyByEmail" to "Require"
  - Submit another registration and check the "Confirm your
    registration" page.
- Visit the registration page passing an invalid token:
  /cgi-bin/koha/opac-registration-verify.pl?token=foo
  Check the "Registration invalid" page.
- Enable the "ArticleRequests" system preference and log in to the
  OPAC.
  - Perform a search which will return results.
    - Check the search results page
    - View the detail page for one of the results.
     - Click "Request article."
    - Return to the detail page and click "Place hold."
      - Complete each step of the hold process.
- Enable the "OpacAllowSharingPrivateLists" system preference.
  - Create a private list if necessary.
  - Click the "Share" link
- Locate a serial record and view the detail page.
  - Click the "More details" link under the "Subscriptions" plan
- Enable the system preference "suggestion."
  - From the logged-in user summary page click "Purchase suggestions"
    - Click the "New purchase suggestion" link
- Enable the "AnonSuggestions" and "OPACViewOthersSuggestions" system
  preferences and log out of the OPAC.
  - View the purchase suggestions page.
- Enable the "OpacCloud" system preference and go to the "Subject cloud"
  page. (the feature doesn't need to be configured to test).
- Populate the "RestrictedPageTitle" and "RestrictedPageContent" system
  preferences and navigate directly to /cgi-bin/koha/opac-restrictedpage.pl
  - Remove the contents of "RestrictedPageTitle" and check the page
    again.
- This patch also updates svc/suggestion.tt but I don't know how to test
  it!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi (tcohen) 2023-11-06 14:36:49 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-11-10 07:41:53 UTC 
Depends on Bug 34849 not in 23.05.x