| Summary: | ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | alexbuckley, gmcharlt, kyle.m.hall |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 25560, 30407 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 35692: Unit test
Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided Bug 35692: Unit test Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided |
||
|
Description
Nick Clemens (kidclamp)
2024-01-03 19:39:12 UTC
Created attachment 160499 [details] [review] Bug 35692: Unit test Created attachment 160500 [details] [review] Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided To test: 1 - Set UpdateNotForLoanStatusOnCheckin to: _ALL_: -1: ONLYMESSAGE 2 - Set an item in the catalog as -1/Ordered 3 - Check the item in 4 - Confirm you see the message 5 - View the record details 6 - Item is now for loan 7 - Check item in again, no message 8 - Apply patch, restart all 9 - Set item as not for loan -1/Ordered 10 - Check item in, you see the message 11 - Check it in again, still see message 12 - Check the detail page, item still marked as ordered Hi Nick, I noticed that too! I submitted a patchset in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 but happy for your patchset to be upstreamed instead :) Thanks, Alex Created attachment 160501 [details] [review] Bug 35692: Unit test Signed-off-by: David Nind <david@davidnind.com> Created attachment 160502 [details] [review] Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided To test: 1 - Set UpdateNotForLoanStatusOnCheckin to: _ALL_: -1: ONLYMESSAGE 2 - Set an item in the catalog as -1/Ordered 3 - Check the item in 4 - Confirm you see the message 5 - View the record details 6 - Item is now for loan 7 - Check item in again, no message 8 - Apply patch, restart all 9 - Set item as not for loan -1/Ordered 10 - Check item in, you see the message 11 - Check it in again, still see message 12 - Check the detail page, item still marked as ordered Signed-off-by: David Nind <david@davidnind.com> Hi Nick, There is one difference between this and bug 35293 (the patchset I wrote) and that is 35293 re-adds the reference to ONLYMESSAGE into the UpdateNotForLoanStatusOnCheckin system preference which was also lost between bug 30407 and bug 25560 : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361 Would you like me to copy that patch over to your bug report here? Thanks, Alex (In reply to Alex Buckley from comment #6) > Hi Nick, > > There is one difference between this and bug 35293 (the patchset I wrote) > and that is 35293 re-adds the reference to ONLYMESSAGE into the > UpdateNotForLoanStatusOnCheckin system preference which was also lost > between bug 30407 and bug 25560 : > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361 > > Would you like me to copy that patch over to your bug report here? > > Thanks, > Alex Hi Alex, either way works, you could also just copy my unit test over to the other and then mark them duplicate. I didn't see yours initially because the depends on wasn't marked :-) *** This bug has been marked as a duplicate of bug 35293 *** (In reply to Nick Clemens from comment #7) > (In reply to Alex Buckley from comment #6) > > Hi Nick, > > > > There is one difference between this and bug 35293 (the patchset I wrote) > > and that is 35293 re-adds the reference to ONLYMESSAGE into the > > UpdateNotForLoanStatusOnCheckin system preference which was also lost > > between bug 30407 and bug 25560 : > > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160361 > > > > Would you like me to copy that patch over to your bug report here? > > > > Thanks, > > Alex > > Hi Alex, either way works, you could also just copy my unit test over to the > other and then mark them duplicate. I didn't see yours initially because the > depends on wasn't marked :-) Thanks so much Nick for making those changes! Apologies for not marking the depends on for bug 35293 |