Summary: | Setting suggester on the suggestion edit form does not show library and category | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, lucas |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.03
|
|
Circulation function: | |||
Bug Depends on: | 35744 | ||
Bug Blocks: | 35329 | ||
Attachments: |
Bug 35745: Fix 'Set suggester' of a suggestion
Bug 35745: Fix 'Set suggester' of a suggestion Bug 35745: Fix 'Set suggester' of a suggestion |
Description
Jonathan Druart
2024-01-09 13:52:52 UTC
Created attachment 160697 [details] [review] Bug 35745: Fix 'Set suggester' of a suggestion On the suggestion edit form, if a suggester is selected using the "Set to patron" (and patron search), the details of the selected patron will contained "undefined" for the library's name and patron's category description. Test plan: Edit a suggestion, click "Set to patron", select a patron Notice that with this patch the library's name and patron category is correctly displayed. Created attachment 160713 [details] [review] Bug 35745: Fix 'Set suggester' of a suggestion On the suggestion edit form, if a suggester is selected using the "Set to patron" (and patron search), the details of the selected patron will contained "undefined" for the library's name and patron's category description. Test plan: Edit a suggestion, click "Set to patron", select a patron Notice that with this patch the library's name and patron category is correctly displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 161091 [details] [review] Bug 35745: Fix 'Set suggester' of a suggestion On the suggestion edit form, if a suggester is selected using the "Set to patron" (and patron search), the details of the selected patron will contained "undefined" for the library's name and patron's category description. Test plan: Edit a suggestion, click "Set to patron", select a patron Notice that with this patch the library's name and patron category is correctly displayed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> So again, this one all works as expected and qa scripts are happy.. so I'm going to PQA.. however, I am interested in the choice to use +strings as apposed to library/category embeds. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 |