Bug 35755

Summary: Upgrade Business::ISBN to at least 3.008 minimum version
Product: Koha Reporter: David Cook <dcook>
Component: PackagingAssignee: Lucas Gass <lucas>
Status: Pushed to main --- QA Contact: Tomás Cohen Arazi <tomascohen>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, lucas, martin.renvoize, mtj, tomascohen
Version: MainKeywords: dependency
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 35729    
Attachments: Bug 35755: Update cpanfile for Business::ISBN 3.008
Bug 35755: Update cpanfile for Business::ISBN 3.008
Bug 35755: Update cpanfile for Business::ISBN 3.008
Bug 35755: Update cpanfile for Business::ISBN 3.009

Description David Cook 2024-01-10 02:30:07 UTC
As Lucas notes at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729#c2 we should upgrade Business::ISBN to handle ISBN-13 with a prefix of 979
Comment 1 David Cook 2024-01-24 01:42:37 UTC
Can someone from the packaging team look at this one?
Comment 2 David Cook 2024-01-24 01:44:50 UTC
I have a library that needs needs an updated Business::ISBN for a Koha plugin they use, so I'm going to download libbusiness-isbn-perl from https://packages.ubuntu.com/mantic/libbusiness-isbn-perl and install it.

It would be good to have the Debian version in the Koha apt repo though.
Comment 3 David Cook 2024-01-24 01:45:40 UTC
Actually looks like the download link for mantic is busted so I'll use the one for noble.

I'll also need the latest libbusiness-isbn-data-perl
Comment 4 Lucas Gass 2024-07-24 14:12:50 UTC
Created attachment 169492 [details] [review]
Bug 35755: Update cpanfile for Business::ISBN 3.008
Comment 5 David Cook 2024-07-25 01:04:09 UTC
Created attachment 169535 [details] [review]
Bug 35755: Update cpanfile for Business::ISBN 3.008

Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 6 David Cook 2024-07-25 01:04:44 UTC
Trying to move this one along.

FYI the one library I have on Business::ISBN 3.008 is doing fine.
Comment 7 Tomás Cohen Arazi 2024-07-25 13:37:16 UTC
Created attachment 169556 [details] [review]
Bug 35755: Update cpanfile for Business::ISBN 3.008

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 8 Tomás Cohen Arazi 2024-07-25 13:43:34 UTC
FTR:

## Bad

* bullseye: 3.006
* bookworm: 3.006
* focal: 3.004
* jammy: 3.006

## Good

* trixie: 3.0009
* noble: 3.009
* mantic (23.10): 3.008

## Conclusion

Needs to be packaged for `bullseye`, `bookworm`, `focal` and `jammy`.
Comment 9 Martin Renvoize 2024-07-26 12:49:02 UTC
Mason.. are you OK to get this packaged up
Comment 10 Tomás Cohen Arazi 2024-07-26 12:58:27 UTC
Should we go 3.0009? (mantic is EOL in a couple months anyway).
Comment 11 Lucas Gass 2024-07-26 13:04:12 UTC
(In reply to Tomás Cohen Arazi from comment #10)
> Should we go 3.0009? (mantic is EOL in a couple months anyway).

I don't see why not.
Comment 12 Katrin Fischer 2024-07-31 15:39:32 UTC
Waiting for feedback from Packaging Manager.
Comment 14 Mason James 2024-08-09 21:53:57 UTC
(In reply to Lucas Gass from comment #11)
> (In reply to Tomás Cohen Arazi from comment #10)
> > Should we go 3.0009? (mantic is EOL in a couple months anyway).
> 
> I don't see why not.

i've added Business::ISBN 3.0009 to the koha-staging/KTD images

lets wait until jenkins test pass, and then add to koha prod apt repo
Comment 15 Katrin Fischer 2024-08-12 15:11:56 UTC
(In reply to Mason James from comment #14)
> (In reply to Lucas Gass from comment #11)
> > (In reply to Tomás Cohen Arazi from comment #10)
> > > Should we go 3.0009? (mantic is EOL in a couple months anyway).
> > 
> > I don't see why not.
> 
> i've added Business::ISBN 3.0009 to the koha-staging/KTD images
> 
> lets wait until jenkins test pass, and then add to koha prod apt repo

Jenkins is looking much greener now - are we ready to move on with this?
Who goes first?
Comment 16 Lucas Gass 2024-08-12 15:44:55 UTC
Created attachment 170232 [details] [review]
Bug 35755: Update cpanfile for Business::ISBN 3.009
Comment 17 Lucas Gass 2024-08-12 15:45:36 UTC
I suspect we should require 3.009?
Comment 18 Katrin Fischer 2024-08-16 14:56:51 UTC
(In reply to Lucas Gass from comment #17)
> I suspect we should require 3.009?

Can you explain what else is needed? It looks like we do:

-requires 'Business::ISBN', '2.05';
+requires 'Business::ISBN', '3.009';
Comment 19 Mason James 2024-08-19 14:14:15 UTC
(In reply to Katrin Fischer from comment #18)
> (In reply to Lucas Gass from comment #17)
> > I suspect we should require 3.009?
> 
> Can you explain what else is needed? It looks like we do:
> 
> -requires 'Business::ISBN', '2.05';
> +requires 'Business::ISBN', '3.009';

yep, thats all that is needed :)
Comment 20 Katrin Fischer 2024-08-19 14:59:59 UTC
Pushed for 24.11!

Well done everyone, thank you!