Bug 21821 - We should bundle an up to date RangeMessage.xml for Business::ISBN
Summary: We should bundle an up to date RangeMessage.xml for Business::ISBN
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-13 13:38 UTC by Martin Renvoize
Modified: 2018-11-13 13:41 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2018-11-13 13:38:06 UTC
Business::ISBN::Data isn't especially maintained and suggests using an up to date RangeMessage.xml file from https://www.isbn-international.org/range_file_generation.

We should bundle a more up to date RangeMessage file with koha and set the appropriate environment in both plack and apache to point to the bundled version.

This would help with new ISBN's that are not yet in the shipped Business::ISBN::Data package.
Comment 1 Martin Renvoize 2018-11-13 13:41:30 UTC
In a mojo app I once build I had the followup in a bootstrap routine at application startup.

  # Ensure we're using an up to date set of data in Business::ISBN
  my $ISBN_RANGE_FILE = $app->home->rel_file('lib/Business/ISBN/RangeMessage.xml');
  $ENV{'ISBN_RANGE_MESSAGE'} = "$ISBN_RANGE_FILE";

We could add similar to the plack start script and a SetEnv to the apache configs based on where we chose to store the file..

To keep this file up to date, I would envisage part of the release workflow being the download and replacement of the RangeMessage file.