Summary: | Wrong use of encodeURIComponent in patron-search.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, kyle, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.02,23.05.09
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 35329 | ||
Attachments: |
Bug 35756: Correctly serialize patron's data in patron search popup/modal
Bug 35756: Correctly serialize patron's data in patron search popup/modal Bug 35756: Correctly serialize patron's data in patron search popup/modal |
Description
Jonathan Druart
2024-01-10 07:54:41 UTC
Created attachment 160732 [details] [review] Bug 35756: Correctly serialize patron's data in patron search popup/modal We are incorrectly using encodeURIComponent in patron-search.inc. When a new patron is selected, the info message is showing "Patron %s is already in the list" or "Patron %s added". If the patron has space in their name, they will be substituted with %20. We are using JSON for select, we can reuse it for add. Test plan: Have a patron with spaces in their name Add users to a fund Notice that the name is correctly displayed. Created attachment 160795 [details] [review] Bug 35756: Correctly serialize patron's data in patron search popup/modal We are incorrectly using encodeURIComponent in patron-search.inc. When a new patron is selected, the info message is showing "Patron %s is already in the list" or "Patron %s added". If the patron has space in their name, they will be substituted with %20. We are using JSON for select, we can reuse it for add. Test plan: Have a patron with spaces in their name Add users to a fund Notice that the name is correctly displayed. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 160966 [details] [review] Bug 35756: Correctly serialize patron's data in patron search popup/modal We are incorrectly using encodeURIComponent in patron-search.inc. When a new patron is selected, the info message is showing "Patron %s is already in the list" or "Patron %s added". If the patron has space in their name, they will be substituted with %20. We are using JSON for select, we can reuse it for add. Test plan: Have a patron with spaces in their name Add users to a fund Notice that the name is correctly displayed. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.02 Backported to 23.05.x for upcoming 23.05.09 |