Summary: | Barcode.pl does not cater variable length branch codes in hbyymmincr format | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Cataloging | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED DUPLICATE | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | koha.sekjal, sophie.meynieux |
Version: | 3.4 | ||
Hardware: | PC | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed fix for bug 3577
screenshot |
Description
Chris Cormack
2010-05-21 01:12:28 UTC
Created attachment 3024 [details] [review] Proposed fix for bug 3577 Katrin to test (for bug 5659) *** Bug 5659 has been marked as a duplicate of this bug. *** Created attachment 3032 [details]
screenshot
Hi sekjal,
the patch works great for the example libraries which all have 3 letter branchcodes. We use the ISIL as branchcode for our libraries. After I added a new library using the ISIL only the next barcode was generated correctly. After that the same barcode was being generated again and again. After I deleted the item for the ISL branch, the barcodes were generated correctly again. (see screensot)
This is marked as Failed QA, but I'm seeing an equivalent fix in the current HEAD... can anyone confirm that this is still an issue? I tested this on current master and still see problems and with the change form the patch: 1) Turn system preference autobarcode to hbyymmincr 2) Add items to a new record a) Add 2 items for branch MPL - Midway. Works. (MPL11070001,MPL11070002) b) Add 1 item for branch DE-576 - works. (DE-57611070003) c) Add 2nd item for branch DE-576 (DE-57611070003 - duplicate!) Perhaps the - in the branch code is the cause of the problem. I can add 1 item for it at the time, and add MPL items after it. But it's not possible to add 2 items in a row for DE-576. Yes, the pb is the - in the branchcode. This is corrected with patch proposed in bug 6474 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6474 |