|
Description
Martin Renvoize (ashimema)
2024-01-15 16:25:51 UTC
Created attachment 161048 [details] [review] Bbug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. I'm sure this could be prettier.. and I wasn't sure whether the new feedback should disappear after a short timeout. We don't have any form of feedback on modals like this as yet.. we need to come up with a pattern and best practice. Created attachment 161058 [details] [review] Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 161059 [details] [review] Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Thanks Owen :) Created attachment 161086 [details] [review] Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 161087 [details] [review] Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 34862 is going to make sure we have "messages.inc" included everywhere (the context is CSRF token alert there). It would be nice to have this #transient_result node moved to this include file. Sounds like a great plan to me, I'll code it up now on its own bug linked to here and 34862 Created attachment 162263 [details] [review] Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 162264 [details] [review] Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 162265 [details] [review] Bug 35813: Migrate 'transient_result' to 'messages.inc' This patch DRY's out the code by migrating the transient_result div into the now widely included messages.inc include. Created attachment 163561 [details] [review] Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 163562 [details] [review] Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 163563 [details] [review] Bug 35813: Migrate 'transient_result' to 'messages.inc' This patch DRY's out the code by migrating the transient_result div into the now widely included messages.inc include. Trivial rebase to put it after the js tidy patch in the queue. Created attachment 166579 [details] [review] Bug 35813: Add success feedback after placing/editing bookings This patch restores the lost behaviour that a successful add/edit of a booking via the 'Place booking' modal should notify the end user that the submission was sucessful. Test plan 1) Set an item as bookable to expose the 'Place booking' button 2) Place a new booking from the following pages and confirm that you now recieve feedback. * Catalog > Title > Details * Catalog > Title > MARC details * Catalog > Title > ISBD details * Catalog > Title > Item details * Catalog > Title > Bookings 3) Edit a booking on the 'Catalog > Title > Bookings' page and confirm you now recieve feedback. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 166580 [details] [review] Bug 35813: (follow-up) Correct dialog class and clean up whitespace This patch changes the class of the success message from "success" (which is a Bootstrap class) to "message" which is the class we use elsewhere in Koha for this kind of informational message. The patch adds the same dialog markup to labeledMARCdetail.tt. The patch also trims trailing whitespace from place_booking_modal.js Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 166581 [details] [review] Bug 35813: Migrate 'transient_result' to 'messages.inc' This patch DRY's out the code by migrating the transient_result div into the now widely included messages.inc include. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> We need the double underscore in a .js file, fixed inline.
+ _("Booking successfully updated") +
Pushed for 24.05! Well done everyone, thank you! Depends on Bug 36374 not in 23.11.1x |