| Summary: | Fix few noisy warnings from C4/Koha and search | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, phil |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 25790 | ||
| Attachments: |
Bug 35833: Fix warnings from C4/Koha
Bug 35833: Silence few warnings from searching Bug 35833: Fix warnings from C4/Koha Bug 35833: Silence few warnings from searching |
||
|
Description
Marcel de Rooy
2024-01-18 13:39:34 UTC
Created attachment 161136 [details] [review] Bug 35833: Fix warnings from C4/Koha [2024/01/18 11:52:40] [WARN] Argument " " isn't numeric in numeric eq (==) at /usr/share/koha/C4/Koha.pm line 600. [2024/01/18 11:52:40] [WARN] Argument " " isn't numeric in numeric eq (==) at /usr/share/koha/C4/Koha.pm line 659. Note: According to the code in MARC::Field the indicator returned cannot be undef. So we do not return new uninitialized warnings. Test plan: Check your log before and after patch. Possibly you may need to create a record with spaces as field indicators. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 161138 [details] [review] Bug 35833: Silence few warnings from searching Resolve: [2024/01/18 11:31:24] [WARN] Use of uninitialized value $hits in numeric eq (==) at /usr/share/koha/opac/opac-search.pl line 612. [2024/01/18 11:31:24] [WARN] Use of uninitialized value $times in subtraction (-) at /usr/share/koha/C4/Search.pm line 1715. Test plan: Look for a few search expressions without results. Check log without and with patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial + architecture. Self SO Created attachment 161389 [details] [review] Bug 35833: Fix warnings from C4/Koha [2024/01/18 11:52:40] [WARN] Argument " " isn't numeric in numeric eq (==) at /usr/share/koha/C4/Koha.pm line 600. [2024/01/18 11:52:40] [WARN] Argument " " isn't numeric in numeric eq (==) at /usr/share/koha/C4/Koha.pm line 659. Note: According to the code in MARC::Field the indicator returned cannot be undef. So we do not return new uninitialized warnings. Test plan: Check your log before and after patch. Possibly you may need to create a record with spaces as field indicators. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 161390 [details] [review] Bug 35833: Silence few warnings from searching Resolve: [2024/01/18 11:31:24] [WARN] Use of uninitialized value $hits in numeric eq (==) at /usr/share/koha/opac/opac-search.pl line 612. [2024/01/18 11:31:24] [WARN] Use of uninitialized value $times in subtraction (-) at /usr/share/koha/C4/Search.pm line 1715. Test plan: Look for a few search expressions without results. Check log without and with patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 |