| Summary: | Use template wrapper for tabs: Curbside pickups administration | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | loic.vassaux-artur, lucas, lucasmontoya, martin.renvoize, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement makes structural changes to the way the curbside pickups administration page is generated for more consistency and ease of upgrade to new Bootstrap versions.
|
Version(s) released in: |
24.11.00
|
| Circulation function: | |||
| Bug Depends on: | 32571 | ||
| Bug Blocks: | 37835 | ||
| Attachments: |
Bug 35838: Use template wrapper for tabs: Curbside pickups administration
Bug 35838: Use template wrapper for tabs: Curbside pickups administration Bug 35838: Use template wrapper for tabs: Curbside pickups administration Bug 35838: Use template wrapper for tabs: Curbside pickups administration Bug 35838: Use template wrapper for tabs: Curbside pickups administration Bug 35838: Fix addition of new slots |
||
|
Description
Owen Leonard
2024-01-18 16:20:44 UTC
Created attachment 161143 [details] [review] Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. It works Created attachment 161239 [details] [review] Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> Created attachment 165264 [details] [review] Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> Created attachment 170341 [details] [review] Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 170653 [details] [review] Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.11! Well done everyone, thank you! Created attachment 171022 [details] [review] Bug 35838: Fix addition of new slots The "Add" button didn't add new slots. *** Bug 37835 has been marked as a duplicate of this bug. *** Pushed follow-up to main. Does this still need additional_work_needed? (In reply to Owen Leonard from comment #11) > Does this still need additional_work_needed? Nope, removed. |