Summary: | No such thing as Koha::Exceptions::Exception | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | Pushed to oldstable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.03,23.05.09
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 35962 | ||
Attachments: |
Bug 35843: Correct invalid exception
Bug 35843: Correct invalid exception Bug 35843: Correct invalid exception |
Description
Magnus Enger
2024-01-19 08:51:04 UTC
Looks like the code was changed from Koha::Exception->throw('Job has not been enqueued'); to Koha::Exceptions::Exception->throw('Job has not been enqueued'); by bug 30172: https://git.koha-community.org/Koha-community/Koha/commit/7585db29c08078d2b85faf27d110c4598e03881d Looks like there was Koha::Exceptions::Exception, but it was changed to Koha::Exception by bug 29857. Created attachment 161177 [details] [review] Bug 35843: Correct invalid exception Test plan: Run background job tests. Especially the changed one. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 161181 [details] [review] Bug 35843: Correct invalid exception Test plan: Run background job tests. Especially the changed one. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Magnus Enger <magnus@libriotech.no> All test pass when running this: prove t/db_dependent/Koha/BackgroundJobs* Created attachment 161311 [details] [review] Bug 35843: Correct invalid exception Test plan: Run background job tests. Especially the changed one. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Magnus Enger <magnus@libriotech.no> All test pass when running this: prove t/db_dependent/Koha/BackgroundJobs* Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 Backported to 23.05.x for upcoming 23.05.09 |