Bug 35962 - t/db_dependent/Koha/BackgroundJob.t failing on D10
Summary: t/db_dependent/Koha/BackgroundJob.t failing on D10
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 35843
Blocks:
  Show dependency tree / graph
 
Reported: 2024-01-31 15:16 UTC by Katrin Fischer
Modified: 2024-02-13 15:38 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.09
Circulation function:

Attachments
Bug 35962: (bug 35843 follow-up) Fix BackgroundJob.t on D10 (1.09 KB, patch)
2024-01-31 15:46 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 35962: (bug 35843 follow-up 2) Fix BackgroundJob.t on D10 (1.11 KB, patch)
2024-02-06 07:32 UTC, Jonathan Druart 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-01-31 15:16:52 UTC 
Not failing locally, but on D10:

koha_1       | 
koha_1       |     #   Failed test 'Enqueue MARCImportCommitBatch with mock throws exception'
koha_1       |     #   at t/db_dependent/Koha/BackgroundJob.t line 85.
koha_1       |     # expecting: Koha::Exceptions::BackgroundJob
koha_1       |     # found: normal exit
koha_1       |     # Looks like you planned 10 tests but ran 2.
koha_1       |     # Looks like you failed 1 test of 2 run.
koha_1       | 
koha_1       | #   Failed test 'enqueue() tests'
koha_1       | #   at t/db_dependent/Koha/BackgroundJob.t line 128.
koha_1       | Can't locate object method "unmock" via package "0" (perhaps you forgot to load "0"?) at t/db_dependent/Koha/BackgroundJob.t line 87.
koha_1       | # Looks like your test exited with 255 just after 2.
koha_1       | [14:12:00] t/db_dependent/Koha/BackgroundJob.t ......................................... 
koha_1       | Dubious, test returned 255 (wstat 65280, 0xff00)
koha_1       | Failed 4/5 subtests 


Coudl this be related to bug 35507 or bug 30734?
Comment 1 Jonathan Druart 2024-01-31 15:46:30 UTC 
Created attachment 161694 [details] [review]
Bug 35962: (bug 35843 follow-up) Fix BackgroundJob.t on D10
Comment 2 Katrin Fischer 2024-02-02 08:33:59 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 3 Katrin Fischer 2024-02-02 09:46:31 UTC 
It looks like D10 is still unhappy - could you have another look at it?
Comment 4 Jonathan Druart 2024-02-06 07:32:53 UTC 
Created attachment 161771 [details] [review]
Bug 35962: (bug 35843 follow-up 2) Fix BackgroundJob.t on D10
Comment 5 Jonathan Druart 2024-02-06 07:33:24 UTC 
Sorry, I simplified the code that was passing on D10, but only tested on D12 it seems...
Comment 7 Jonathan Druart 2024-02-06 08:00:21 UTC 
I pushed the second patch to master.
Comment 8 Katrin Fischer 2024-02-06 12:39:41 UTC 
(In reply to Jonathan Druart from comment #7)
> I pushed the second patch to master.

I am still here you know ;) But it's good. I was just about to.
Comment 9 Fridolin Somers 2024-02-13 10:36:02 UTC 
Pushed to 23.11.x for 23.11.03
Comment 10 Lucas Gass (lukeg) 2024-02-13 15:38:40 UTC 
Backported to 23.05.x for upcoming 23.05.09