Summary: | Use template wrapper for tabs: Header search forms | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.aubeut, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Bug Depends on: | 32571 | ||
Bug Blocks: | 36469, 36490 | ||
Attachments: |
Bug 35850: Use template wrapper for tabs: Header search forms
Bug 35850: Use template wrapper for tabs: Header search forms Bug 35850: Use template wrapper for tabs: Header search forms Bug 35850: Use template wrapper for tabs: Header search forms |
Description
Owen Leonard
2024-01-19 13:42:31 UTC
Created attachment 161252 [details] [review] Bug 35850: Use template wrapper for tabs: Header search forms This patch updates search header includes so that the tabs use WRAPPER to build markup. To test, apply the patch and test at least one page which uses each updated search include. Search header tabs should look correct and work correctly. - Acquisitions - Suggestions - Administration - Budgets and funds - Cities - Currencies - Desks - Patron categories - System preferences - Z39.50 - Advanced search - Authorities - Bibliographic detail page - Cataloging home page - Check in - Check out - Acquisitions -> Vendor -> Contracts - ERM - Staff interface home page - Serials - Tool -> Notices Created attachment 161298 [details] [review] Bug 35850: Use template wrapper for tabs: Header search forms This patch updates search header includes so that the tabs use WRAPPER to build markup. To test, apply the patch and test at least one page which uses each updated search include. Search header tabs should look correct and work correctly. - Acquisitions - Suggestions - Administration - Budgets and funds - Cities - Currencies - Desks - Patron categories - System preferences - Z39.50 - Advanced search - Authorities - Bibliographic detail page - Cataloging home page - Check in - Check out - Acquisitions -> Vendor -> Contracts - ERM - Staff interface home page - Serials - Tool -> Notices Signed-off-by: Martin AUBEUT <martin.aubeut@gmail.com> Created attachment 161497 [details] [review] Bug 35850: Use template wrapper for tabs: Header search forms This patch updates search header includes so that the tabs use WRAPPER to build markup. To test, apply the patch and test at least one page which uses each updated search include. Search header tabs should look correct and work correctly. - Acquisitions - Suggestions - Administration - Budgets and funds - Cities - Currencies - Desks - Patron categories - System preferences - Z39.50 - Advanced search - Authorities - Bibliographic detail page - Cataloging home page - Check in - Check out - Acquisitions -> Vendor -> Contracts - ERM - Staff interface home page - Serials - Tool -> Notices Signed-off-by: Martin AUBEUT <martin.aubeut@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great work, Passing QA Created attachment 163520 [details] [review] Bug 35850: Use template wrapper for tabs: Header search forms This patch updates search header includes so that the tabs use WRAPPER to build markup. To test, apply the patch rebuild the staff interface CSS. Test at least one page which uses each updated search include. Search header tabs should look correct and work correctly. - Acquisitions - Suggestions - Administration - Budgets and funds - Cities - Currencies - Desks - Patron categories - System preferences - Z39.50 - Advanced search - Authorities - Bibliographic detail page - Cataloging home page - Check in - Check out - Acquisitions -> Vendor -> Contracts - ERM - Staff interface home page - Serials - Tool -> Notices Signed-off-by: Martin AUBEUT <martin.aubeut@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.05! Well done everyone, thank you! It looks like we broke some cypress tests with this one because IDs changed: t/cypress/integration/ERM/Searchbar_spec.ts Working on a fix. Follow-up will be pushed to master. |