Bug 35850 - Use template wrapper for tabs: Header search forms
Summary: Use template wrapper for tabs: Header search forms
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 32571
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-19 13:42 UTC by Owen Leonard
Modified: 2024-01-26 10:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35850: Use template wrapper for tabs: Header search forms (92.13 KB, patch)
2024-01-22 16:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35850: Use template wrapper for tabs: Header search forms (92.18 KB, patch)
2024-01-23 14:20 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 35850: Use template wrapper for tabs: Header search forms (92.30 KB, patch)
2024-01-26 10:02 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-01-19 13:42:31 UTC
Continuing the work of Bug 32571, I would like to update the header search form include files in the staff client to use the new WRAPPER for tabs
Comment 1 Owen Leonard 2024-01-22 16:00:37 UTC
Created attachment 161252 [details] [review]
Bug 35850: Use template wrapper for tabs: Header search forms

This patch updates search header includes so that the tabs use WRAPPER
to build markup.

To test, apply the patch and test at least one page which uses each
updated search include. Search header tabs should look correct and work
correctly.

- Acquisitions
  - Suggestions
- Administration
    - Budgets and funds
    - Cities
    - Currencies
    - Desks
    - Patron categories
    - System preferences
    - Z39.50
- Advanced search
- Authorities
- Bibliographic detail page
- Cataloging home page
- Check in
- Check out
- Acquisitions -> Vendor -> Contracts
- ERM
- Staff interface home page
- Serials
- Tool -> Notices
Comment 2 Biblibre Sandboxes 2024-01-23 14:20:56 UTC
Created attachment 161298 [details] [review]
Bug 35850: Use template wrapper for tabs: Header search forms

This patch updates search header includes so that the tabs use WRAPPER
to build markup.

To test, apply the patch and test at least one page which uses each
updated search include. Search header tabs should look correct and work
correctly.

- Acquisitions
  - Suggestions
- Administration
    - Budgets and funds
    - Cities
    - Currencies
    - Desks
    - Patron categories
    - System preferences
    - Z39.50
- Advanced search
- Authorities
- Bibliographic detail page
- Cataloging home page
- Check in
- Check out
- Acquisitions -> Vendor -> Contracts
- ERM
- Staff interface home page
- Serials
- Tool -> Notices

Signed-off-by: Martin AUBEUT <martin.aubeut@gmail.com>
Comment 3 Martin Renvoize 2024-01-26 10:02:48 UTC
Created attachment 161497 [details] [review]
Bug 35850: Use template wrapper for tabs: Header search forms

This patch updates search header includes so that the tabs use WRAPPER
to build markup.

To test, apply the patch and test at least one page which uses each
updated search include. Search header tabs should look correct and work
correctly.

- Acquisitions
  - Suggestions
- Administration
    - Budgets and funds
    - Cities
    - Currencies
    - Desks
    - Patron categories
    - System preferences
    - Z39.50
- Advanced search
- Authorities
- Bibliographic detail page
- Cataloging home page
- Check in
- Check out
- Acquisitions -> Vendor -> Contracts
- ERM
- Staff interface home page
- Serials
- Tool -> Notices

Signed-off-by: Martin AUBEUT <martin.aubeut@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2024-01-26 10:04:25 UTC
Great work, Passing QA