Summary: | Update display of Clear and Cancel links in the authority search pop-up window | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
Circulation function: | |||
Bug Depends on: | 34343 | ||
Bug Blocks: | 38066 | ||
Attachments: |
Bug 35857: Update authority search pop-up windows with consistent footer markup
Bug 35857: Update authority search pop-up windows with consistent footer markup Bug 35857: Update authority search pop-up windows with consistent footer markup |
Description
Caroline Cyr La Rose
2024-01-22 15:53:34 UTC
Created attachment 161560 [details] [review] Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data. Created attachment 161562 [details] [review] Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 163693 [details] [review] Bug 35857: Update authority search pop-up windows with consistent footer markup This patch updates the cataloging authority finder template in order to style submission and close buttons in a fixed footer at the bottom of the pop-up window, with markup consistent with other pop-up windows. Some inline CSS has been removed in favor of styling the "Clear" button like a default button. Unrelated, "No results found" message has been wrapped in a "dialog message" div for consistency's sake. To test, apply the patch and go to Cataloging -> New record. - In the "Add MARC record" form, locate a tag which is linked to an authority type, e.g. 100$a. - Click the icon to the right of the field to trigger the authority search window. - There should be a fixed footer in the pop-up window with buttons for "Submit," "Clear form," and "Close window." Test that each behave correctly. - The search results view should have the same footer. - Clicking "Choose" from the search results should close the window and populate the MARC tag with the correct authority data. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Doesn't apply cleanly to 23.05.x, no backport. |