| Summary: | Use template wrapper for accordions: Notices | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Julian Maurice <julian.maurice> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, julian.maurice, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 35877 | ||
| Bug Blocks: | 37059 | ||
| Attachments: |
Bug 35882: Use template wrapper for accordions: Notices
Bug 35882: Use template wrapper for accordions: Notices Bug 35882: Use template wrapper for accordions: Notices Bug 35882: (QA follow-up) Fix wrapper parameter (panelgroup_id) |
||
|
Description
Owen Leonard
2024-01-23 19:14:28 UTC
Created attachment 161330 [details] [review] Bug 35882: Use template wrapper for accordions: Notices This patch updates the notices template so that Bootstrap accordion markup for the notice edit view is generated by WRAPPERs. To test, apply the patch and go to Tools -> Notices. - Edit any notice. - The list of message transport types (Email, Print, SMS) should be displayed as before: Collapsible panels where clicking the transport type heading expands the corresponding information. - Confirm that changes to notices are correctly saved. Created attachment 161738 [details] [review] Bug 35882: Use template wrapper for accordions: Notices This patch updates the notices template so that Bootstrap accordion markup for the notice edit view is generated by WRAPPERs. To test, apply the patch and go to Tools -> Notices. - Edit any notice. - The list of message transport types (Email, Print, SMS) should be displayed as before: Collapsible panels where clicking the transport type heading expands the corresponding information. - Confirm that changes to notices are correctly saved. Signed-off-by: David Nind <david@davidnind.com> Created attachment 163890 [details] [review] Bug 35882: Use template wrapper for accordions: Notices This patch updates the notices template so that Bootstrap accordion markup for the notice edit view is generated by WRAPPERs. To test, apply the patch and go to Tools -> Notices. - Edit any notice. - The list of message transport types (Email, Print, SMS) should be displayed as before: Collapsible panels where clicking the transport type heading expands the corresponding information. - Confirm that changes to notices are correctly saved. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 163891 [details] [review] Bug 35882: (QA follow-up) Fix wrapper parameter (panelgroup_id) Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed for 24.05! Well done everyone, thank you! Enhancement not backported Code structure change, nothing to add/edit in the manual. |