|
Description
Nick Clemens (kidclamp)
2024-01-25 19:36:50 UTC
Created attachment 161462 [details] [review] Bug 35912: Corretc field name form itemprice to price in addorderiso2709 template To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items do no have prices Cancel Apply patch Add to basket from file again Note prices, and other fields, come through as expected Created attachment 161463 [details]
Test Order file
Created attachment 161470 [details] [review] Bug 35912: Corretc field name form itemprice to price in addorderiso2709 template To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items do no have prices Cancel Apply patch Add to basket from file again Note prices, and other fields, come through as expected Signed-off-by: Michelle Spinney <mspinney@clamsnet.org> (In reply to ByWater Sandboxes from comment #3) > Bug 35912: Corretc field name form itemprice to price in addorderiso2709 Yeah, corretc :) Created attachment 161483 [details] [review] Bug 35912: Corretc field name form itemprice to price in addorderiso2709 template To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items do no have prices Cancel Apply patch Add to basket from file again Note prices, and other fields, come through as expected Signed-off-by: Michelle Spinney <mspinney@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.03 Created attachment 161716 [details] [review] Bug 35912: Corretc field name form itemprice to price in addorderiso2709 template To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items do no have prices Cancel Apply patch Add to basket from file again Note prices, and other fields, come through as expected Signed-off-by: Michelle Spinney <mspinney@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Apologies for the stray sign-off, it was a sandbox error. May we have a backport for this to 23.05? This should not be needed for 23.05 - caused by 33170 - so only in 23.11 and after Missing dependency for 23.05.x, no backport. |