Bug 32166 added the import_record_id to the name for the replacementprice field, however, this made it clash with the record level replacement price - that field doesn't populate when we are using MarcItemFieldsToOrder and so is $0 When fetching the item prices, we get an array which inlcudes that $0 and so the order replacement prices appear correctly in the form, but are not saved to the database We need to rename the input field
Created attachment 161955 [details] [review] Bug 36053: Correct input name for item replacement fields To test: 1 - Follow test plan and use sample record from bug 35912 ( or similar) 2 - Confirm that when the order is saved the replacement price is $0.00 3 - Apply patch, restart_all 4 - Delete previous orders, and stage and add to basket again 5 - Confirm that upon adding orders to basket the replacement price is saved correctly
Created attachment 162063 [details] [review] Bug 36053: Correct input name for item replacement fields To test: 1 - Follow test plan and use sample record from bug 35912 ( or similar) 2 - Confirm that when the order is saved the replacement price is $0.00 3 - Apply patch, restart_all 4 - Delete previous orders, and stage and add to basket again 5 - Confirm that upon adding orders to basket the replacement price is saved correctly Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
We noticed this bug and are adding a comment to let you know we are interested in a fix! Thanks.
(In reply to Erin A. from comment #3) > We noticed this bug and are adding a comment to let you know we are > interested in a fix! Thanks. Hi Erin :) This bug already has a patch and is in "Signed off", which means it will be reviewed by the QA team next and if it passes (everything works etc.) it will be included in Koha. As a bug it's likely to be backported into stable versions as well. Please keep commenting!
This causes loss of data during order/record import - raising to major
+1 I very much agree that this is a major problem for us.
Created attachment 164448 [details] [review] Bug 36053: Correct input name for item replacement fields To test: 1 - Follow test plan and use sample record from bug 35912 ( or similar) 2 - Confirm that when the order is saved the replacement price is $0.00 3 - Apply patch, restart_all 4 - Delete previous orders, and stage and add to basket again 5 - Confirm that upon adding orders to basket the replacement price is saved correctly Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.05
Just curious if this bug could be backported to 23.05?
Backported to 23.05.x for upcoming 23.05.12