Summary: | Item order prices do not fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Pushed to oldstable --- | QA Contact: | Victor Grousset/tuxayo <victor> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, blawlor, fridolin.somers, koha, mspinney, phil, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36053 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.04
|
|
Circulation function: | |||
Bug Depends on: | 33170 | ||
Bug Blocks: | |||
Attachments: |
Bug 35913 - Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder
Test order file Bug 35913 - Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder Bug 35913: Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder |
Description
Nick Clemens (kidclamp)
2024-01-25 19:56:08 UTC
Created attachment 161464 [details] [review] Bug 35913 - Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items have prices Cancel Remove 'price' mapping from MarcItemFieldsToOrder Apply patch Add to basket from file again Note item prices, and other fields, come through as expected Created attachment 161465 [details]
Test order file
Created attachment 161717 [details] [review] Bug 35913 - Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items have prices Cancel Remove 'price' mapping from MarcItemFieldsToOrder Apply patch Add to basket from file again Note item prices, and other fields, come through as expected Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 162313 [details] [review] Bug 35913: Restore price fall back to MarcFieldsToOrder if not set by MarcItemFieldsToOrder To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Select the biblio Note items have prices Cancel Remove 'price' mapping from MarcItemFieldsToOrder Apply patch Add to basket from file again Note item prices, and other fields, come through as expected Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Works, makes sense, QA script happy, code looks good, passing QA :) Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.04 |