| Summary: | Wrong branch picked after an incorrect login | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to stable --- | QA Contact: | Julian Maurice <julian.maurice> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, julian.maurice, lucas |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.04,23.05.10
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 34478 | ||
| Attachments: |
Bug 35935: Ensure login branch will be used after incorrect login
Bug 35935: Ensure login branch will be used after incorrect login Bug 35935: Ensure login branch will be used after incorrect login |
||
|
Description
Jonathan Druart
2024-01-30 08:01:50 UTC
Created attachment 161623 [details] [review] Bug 35935: Ensure login branch will be used after incorrect login If a different branch is selected after an incorrect login, the previous branch will be used. To recreate: * login with foo/bar, select CPL => FAIL * login with koha/koha, select another branch => OK but CPL is picked! It was caused by a dup of "branch" in CGI param list (and first was picked). This patch patch also removes "koha_login_context" to not have it twice. You can also open the source of the page to confirm that form#loginform contains "branch" and "koha_login_context" in hidden inputs. Created attachment 161625 [details] [review] Bug 35935: Ensure login branch will be used after incorrect login If a different branch is selected after an incorrect login, the previous branch will be used. To recreate: * login with foo/bar, select CPL => FAIL * login with koha/koha, select another branch => OK but CPL is picked! It was caused by a dup of "branch" in CGI param list (and first was picked). This patch patch also removes "koha_login_context" to not have it twice. You can also open the source of the page to confirm that form#loginform contains "branch" and "koha_login_context" in hidden inputs. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested in KTD. Works as advertised. Created attachment 162236 [details] [review] Bug 35935: Ensure login branch will be used after incorrect login If a different branch is selected after an incorrect login, the previous branch will be used. To recreate: * login with foo/bar, select CPL => FAIL * login with koha/koha, select another branch => OK but CPL is picked! It was caused by a dup of "branch" in CGI param list (and first was picked). This patch patch also removes "koha_login_context" to not have it twice. You can also open the source of the page to confirm that form#loginform contains "branch" and "koha_login_context" in hidden inputs. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested in KTD. Works as advertised. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 24.05.00. Pushed to 23.11.x for 23.11.04 Backported to 23.05.x for upcoming 23.05.10. |