Bug 35935

Summary: Wrong branch picked after an incorrect login
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to stable --- QA Contact: Julian Maurice <julian.maurice>
Severity: major    
Priority: P5 - low CC: fridolin.somers, gmcharlt, julian.maurice, lucas
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Bug Depends on:    
Bug Blocks: 34478    
Attachments: Bug 35935: Ensure login branch will be used after incorrect login
Bug 35935: Ensure login branch will be used after incorrect login
Bug 35935: Ensure login branch will be used after incorrect login

Description Jonathan Druart 2024-01-30 08:01:50 UTC
If a different branch is selected after an incorrect login, the previous branch will be used.

To recreate:
* login with foo/bar, select CPL => FAIL
* login with koha/koha, select another branch => OK but CPL is picked!
Comment 1 Jonathan Druart 2024-01-30 08:06:22 UTC Comment hidden (obsolete)
Comment 2 Magnus Enger 2024-01-30 09:03:39 UTC
Created attachment 161625 [details] [review]
Bug 35935: Ensure login branch will be used after incorrect login

If a different branch is selected after an incorrect login, the previous branch will be used.

To recreate:
* login with foo/bar, select CPL => FAIL
* login with koha/koha, select another branch => OK but CPL is picked!

It was caused by a dup of "branch" in CGI param list (and first was picked).

This patch patch also removes "koha_login_context" to not have it twice.
You can also open the source of the page to confirm that form#loginform
contains "branch" and "koha_login_context" in hidden inputs.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tested in KTD. Works as advertised.
Comment 3 Julian Maurice 2024-02-16 09:12:31 UTC
Created attachment 162236 [details] [review]
Bug 35935: Ensure login branch will be used after incorrect login

If a different branch is selected after an incorrect login, the previous
branch will be used.

To recreate:
* login with foo/bar, select CPL => FAIL
* login with koha/koha, select another branch => OK but CPL is picked!

It was caused by a dup of "branch" in CGI param list (and first was
picked).

This patch patch also removes "koha_login_context" to not have it twice.
You can also open the source of the page to confirm that form#loginform
contains "branch" and "koha_login_context" in hidden inputs.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Tested in KTD. Works as advertised.
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Jonathan Druart 2024-03-01 13:19:58 UTC
Pushed to master for 24.05.00.
Comment 5 Fridolin Somers 2024-03-11 09:02:14 UTC
Pushed to 23.11.x for 23.11.04
Comment 6 Lucas Gass 2024-03-19 15:00:45 UTC
Backported to 23.05.x for upcoming 23.05.10.